Fix: Incorrect Data Display in Replications Table #21461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bupd <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21461 +/- ##
==========================================
+ Coverage 45.36% 46.12% +0.75%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6404 +355
- Misses 6983 7141 +158
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
Vad1mo
approved these changes
Jan 24, 2025
|
LGTM @bupd after this one is merged would you mind writing another PR to cherry-pick? |
|
@reasonerjt sure. |
|
hope we can merge this one. |
stonezdj
approved these changes
Feb 8, 2025
bupd
added a commit
to bupd/harbor
that referenced
this pull request
Feb 9, 2025
fix incorrect data display in replications table Signed-off-by: bupd <[email protected]>
reasonerjt
pushed a commit
that referenced
this pull request
Feb 10, 2025
… (#21604) Fix: Incorrect Data Display in Replications Table (#21461) fix incorrect data display in replications table Signed-off-by: bupd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Issue being fixed
Fixes #21460
Before
After
Please indicate you've done the following: