cmd/stringer: omit negative bounds check from String() for unsigned integers

Commit 82041a1 ("cmd/stringer: fix bounds checking for integer types spanning
full range") introduced a universal lower bounds check for all integers,
including unsigned ints. Unfortunately, performing a <0 bounds check on a uint
gets flagged by static analysis tools like staticcheck.

This commit only emits the bounds check if the type in question is either
signed or has a non-zero minimum value, in which case the bounds check is
necessary for unsigned types as well.

Signed-off-by: Timo Beckers <[email protected]>

Author: ti-mo

cmd/stringer/stringer.go

@@ -641,14 +641,35 @@ func (g *Generator) buildOneRun(runs [][]Value, typeName string) {
 	values := runs[0]
 	g.Printf("\n")
 	g.declareIndexAndNameVar(values, typeName)
-	g.Printf(stringOneRun, typeName, values[0].String())
+
+	if values[0].signed || values[0].String() != "0" {
+		g.Printf(stringOneRunSigned, typeName, values[0].String())
+	} else {
+		g.Printf(stringOneRun, typeName, values[0].String())
+	}
 }
 
 // Arguments to format are:
 //
 //	[1]: type name
 //	[2]: lowest defined value for type, as a string
 const stringOneRun = `func (i %[1]s) String() string {
+	idx := int(i) - %[2]s
+	if idx >= len(_%[1]s_index)-1 {
+		return "%[1]s(" + strconv.FormatInt(int64(i), 10) + ")"
+	}
+	return _%[1]s_name[_%[1]s_index[idx] : _%[1]s_index[idx+1]]
+}
+`
+
+// Arguments to format are:
+//
+//	[1]: type name
+//	[2]: lowest defined value for type, as a string
+//
+// This is the signed version of [stringOneRun] with an extra bounds check for
+// negative values.
+const stringOneRunSigned = `func (i %[1]s) String() string {
 	idx := int(i) - %[2]s
 	if i < %[2]s || idx >= len(_%[1]s_index)-1 {
 		return "%[1]s(" + strconv.FormatInt(int64(i), 10) + ")"