Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tree_scalar_mul to tree_scale #1196

Open
carlosgmartin opened this issue Feb 15, 2025 · 1 comment · May be fixed by #1198
Open

Rename tree_scalar_mul to tree_scale #1196

carlosgmartin opened this issue Feb 15, 2025 · 1 comment · May be fixed by #1198

Comments

@carlosgmartin
Copy link
Contributor

Minor suggestion: For convenience, rename

which are more concise.

If adopted, this could be done as follows:

  1. Rename the current functions in the code.
  2. Add back the old names as aliases. Make them emit deprecation warnings.
  3. After a deprecation period, delete the old names.

I can submit a PR for this.
This was referenced Feb 16, 2025
Closed
Open
@aryanmahawar205
Copy link

hey @carlosgmartin can you have a look at my PR and help figuring out what's possibly going wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@carlosgmartin @aryanmahawar205