feat: expose credential service in readonly context #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matino
force-pushed
the
expose_credential_service
branch
from
e37ae28 to
d3b500b
Compare
matino
commented
Jul 8, 2025
|
@hangfei Do you think we can merge this? It's a real blocker for my use case (especially passing credential service to the |
seanzhou1023
approved these changes
Jul 11, 2025
seanzhou1023
force-pushed
the
expose_credential_service
branch
from
9531852 to
997b6a9
Compare
seanzhou1023
approved these changes
Jul 11, 2025
seanzhou1023
added
the
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is described in #1816.
TLDR; currently, there's no clean way to pass secrets to the LLM.
This PR makes it possible to access the credential service in a read-only context. It can be use to pass the
authorizationheader to theLlmAgenttool:Runnerinstance, callsave_credential()tool_context.credential_service.load_credential()to load the credential (tool_context is ofToolContexttype)