minor fixes to auto uploader

Author: borisf

.gitignore

@@ -34,3 +34,5 @@ ClassySharkWS/out/
 *.txt
 
 ClassySharkWS/*_dump
+
+ClassySharkWS/ClassyShark*.jar

ClassySharkWS/src/com/google/classyshark/Version.java

@@ -17,10 +17,10 @@
 package com.google.classyshark;
 
 /**
- * This file is the one containg the data for the current ClassyShark version
+ * This file is the one containing the data for the current ClassyShark version
  */
 public class Version {
 
-    public static final int MAJOR = 1;
-    public static final int MINOR = 0;
+    public static final int MAJOR = 6;
+    public static final int MINOR = 4;
 }

ClassySharkWS/src/com/google/classyshark/gui/panel/displayarea/doodles/SharkBG.java

@@ -16,6 +16,8 @@
 
 package com.google.classyshark.gui.panel.displayarea.doodles;
 
+import com.google.classyshark.Version;
+
 /**
  *  the welcome ascii art image
  */
@@ -46,6 +48,7 @@ class SharkBG {
                       + "               ii!                             '*YMWM,                        \n"
                       + "               I'                                  \"YM\n"
                       + "\n\n\n\thttp://www.retrojunkie.com/asciiart/animals/sharks.htm"
-                      + "\n\n\n\tClassyShark ver. 6.4 powered by SilverGhost";
+                      + "\n\n\n\tClassyShark ver." + Version.MAJOR + "."
+                      + Version.MINOR + " powered by SilverGhost";
 
 }

ClassySharkWS/src/com/google/classyshark/updater/UpdateManager.java

@@ -28,8 +28,9 @@
 
 
 /**
- * This class is the core point for the update process: based on the response received from GitHub, it will download
- * the new release and, if ClassyShark has been started as desktop app, when the download finishes, it will show a
+ * This class is the core point for the update process: based on the response
+ * received from GitHub, it will download the new release and, if ClassyShark
+ * has been started as desktop app, when the download finishes, it will show a
  * dialog containing the changelog of the new version
  */
 public class UpdateManager{
@@ -65,7 +66,7 @@ private void checkVersion(boolean isGui) {
         call.enqueue(releaseCallback);
     }
 
-    private void onReleaseResponse(Release release) {
+    private void onReleaseResponse(final Release release) {
         if (release.isNewerThan(currentRelease)) {
             new Thread(new Runnable() {
                 @Override
@@ -85,5 +86,4 @@ private void obtainNew(Release release) {
             System.err.println("ERROR: " + e.getMessage());
         }
     }
-
 }

ClassySharkWS/src/com/google/classyshark/updater/models/Release.java

@@ -16,7 +16,6 @@
 
 package com.google.classyshark.updater.models;
 
-
 import com.google.classyshark.Version;
 import com.google.classyshark.updater.networking.GitHubApi;
 import com.google.gson.annotations.SerializedName;
@@ -37,8 +36,7 @@ public class Release {
     private final ReleaseDownloadData[] assets;
     @SerializedName("created_at")
     private final String createdAt;
-
-
+    
     private Release(String name, boolean preRelease, String body, ReleaseDownloadData[] assets, String createdAt) {
         this.name = name;
         this.preRelease = preRelease;

ClassySharkWS/src/com/google/classyshark/updater/networking/GitHubApi.java

@@ -22,8 +22,8 @@
 import retrofit2.http.GET;
 
 /**
- * This class is the one taking care of representing the API needed in order to retrieve the latest release data from
- * GitHub.
+ * This class is the one taking care of representing the API needed
+ * in order to retrieve the latest release data from GitHub.
  */
 public interface GitHubApi {
 

ClassySharkWS/src/com/google/classyshark/updater/networking/MessageRunnable.java

@@ -21,14 +21,14 @@
 public class MessageRunnable implements Runnable {
     private final String title;
     private final String changelog;
-    private final boolean gui;
+    private final boolean isGui;
 
     private final String ICON_PATH = "/resources/ic_update.png";
 
     public MessageRunnable(String title, String changelog, boolean gui) {
         this.title = buildTitleFrom(title);
         this.changelog = buildChangelogFrom(changelog);
-        this.gui = gui;
+        this.isGui = gui;
     }
 
     private String buildTitleFrom(String title) {
@@ -41,7 +41,7 @@ private String buildChangelogFrom(String changelog) {
 
     @Override
     public void run() {
-        if (gui) {
+        if (isGui) {
             warnUserAboutNewRelease();
         }
     }

ClassySharkWS/src/com/google/classyshark/updater/utils/NamingUtils.java

@@ -16,7 +16,6 @@
 
 package com.google.classyshark.updater.utils;
 
-
 import com.google.classyshark.updater.models.Release;
 import com.sun.istack.internal.NotNull;