Allow unassigned values for labels #114
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would reject the use of numeric label values that do not correspond to an IANA `enum` and which are outside of any defined private range. This made it hard to deal with as-yet-unassigned label values from internet drafts, which are not yet definitive. So add an `Unassigned(i64)` variant to cover these values. This also means that the `UnregisteredIana[NonPrivate]Value` errors can no longer be emitted. Fixes google#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would reject the use of numeric label values that do not correspond to an IANA
enumand which are outside of any defined private range.This made it hard to deal with as-yet-unassigned label values from internet drafts, which are not yet definitive.
So add an
Unassigned(i64)variant to cover these values. This also means that theUnregisteredIana[NonPrivate]Valueerrors can no longer be emitted.Fixes #112