Skip to content

Commit dbe91d6

Browse files
java-team-github-botError Prone Team
authored and
Error Prone Team
committed
Test static mutable check
PiperOrigin-RevId: 590769082
1 parent da7be27 commit dbe91d6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/threadsafety/WellKnownMutability.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ private static ImmutableMap<String, AnnotationInfo> buildImmutableClasses(
299299
.build();
300300
}
301301

302-
private static ImmutableSet<String> buildMutableClasses(List<String> knownMutables) {
302+
public static ImmutableSet<String> buildMutableClasses(List<String> knownMutables) {
303303
return ImmutableSet.<String>builder()
304304
.addAll(knownMutables)
305305
.addAll(ImmutableCollections.MUTABLE_TO_IMMUTABLE_CLASS_NAME_MAP.keySet())
@@ -308,7 +308,8 @@ private static ImmutableSet<String> buildMutableClasses(List<String> knownMutabl
308308
.add(java.util.BitSet.class.getName())
309309
.add(java.util.Calendar.class.getName())
310310
.add(java.lang.Iterable.class.getName())
311-
.add(java.lang.Object.class.getName())
311+
// Everything is a subtype of Object so hack remove it
312+
// .add(java.lang.Object.class.getName())
312313
.add("java.text.DateFormat")
313314
.add(java.util.ArrayList.class.getName())
314315
.add(java.util.Collection.class.getName())

0 commit comments

Comments
 (0)