[Map] Hide "add data" button on site cards for ad hoc jobs

[gino-m]

...only show "Add data" button on sites for predefined sites (ie LOIs imported by survey organizer).

This will simplify the "ad hoc" case, and prevent data collectors from adding data to each others' sites when implementing #3068.

So for predefined sites imported by the survey organizer, data collectors will see:

And for ad hoc sites added by data collectors themselves:

@vittorino @lecrabe @jo-spek FYI

[anandwana001]

This is fixed in one of the old pull requests.

@rfontanarosa could you please test this once from the latest master branch?

[rfontanarosa]

me and Jonas have just verified and the problem is fixed. so we can close this @gino-m @anandwana001

[jo-spek]

Let me elaborate that this was a huge problem with the "Collect data" cards in the older versions, where users had to swipe to the right to "Add a new site" when there was another mapped site already close. Now with the big plus instead this has become a non-issue.

@gino-m I would argue that now that one has to click the existent geometry first to add new data, we don't have to take the "Add data" button out anymore. Maybe call it "Update" instead?

[anandwana001]

@jo-spek Can we create a separate ticket for the above ask?

[gino-m]

@gino-m I would argue that now that one has to click the existing geometry first to add new data, we don't have to take the "Add data" button out anymore. Maybe call it "Update" instead?

We still need to do this, since I don't think the intent is to allow users to submit data multiple times for sites they added. The ability to add multiple submissions to a site was part of Ground's original design to allow crowd sourcing and remeasurement. Those only make sense in the context of jobs with predefined sites, not ones added ad hoc.

Leaving "Add data" on the ad hoc sites will be even more confusing once data collectors can see each other's sites. I'd vote to reopen this.