This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Add pow builtin #373
Open
Add pow builtin #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotterdylan
suggested changes
Aug 3, 2017
Contributor
trotterdylan
left a comment
trotterdylan
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a couple small suggestions.
runtime/builtin_types.go
Outdated
| if raised := checkFunctionArgs(f, "pow", args, expectedTypes...); raised != nil { | ||
| return nil, raised | ||
| } | ||
| v := args[0] |
Contributor
There was a problem hiding this comment.
Can you just call return Pow(f, args[0], args[1]) instead?
| {f: "ord", args: wrapArgs("foo"), wantExc: mustCreateException(ValueErrorType, "ord() expected a character, but string of length 3 found")}, | ||
| {f: "ord", args: wrapArgs(NewUnicode("волн")), wantExc: mustCreateException(ValueErrorType, "ord() expected a character, but string of length 4 found")}, | ||
| {f: "ord", args: wrapArgs(1, 2, 3), wantExc: mustCreateException(TypeErrorType, "'ord' requires 1 arguments")}, | ||
| {f: "pow", args: wrapArgs(1), wantExc: mustCreateException(TypeErrorType, "'pow' requires 2 arguments")}, |
Contributor
There was a problem hiding this comment.
Would be nice to have a couple more test cases, e.g. a negative exponent and a complex number
Contributor
Author
|
@trotterdylan Ready for review! |
This was referenced Oct 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.