Skip to content

Commit 67e0984

Browse files
cpovirkGoogle Java Core Libraries
authored and
Google Java Core Libraries
committed
Check compatibility against the Android SDK (including [always-desugared APIs](https://github.com/open-toast/gummy-bears#android) but still not opt-in library desugaring) instead of the JDK.
Fixes #4005 RELNOTES=n/a PiperOrigin-RevId: 584349750
1 parent 4f12c58 commit 67e0984

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

android/pom.xml

+6-7
Original file line numberDiff line numberDiff line change
@@ -180,15 +180,14 @@
180180
<annotations>com.google.common.collect.IgnoreJRERequirement,com.google.common.hash.IgnoreJRERequirement,com.google.common.io.IgnoreJRERequirement,com.google.common.reflect.IgnoreJRERequirement,com.google.common.testing.IgnoreJRERequirement</annotations>
181181
<checkTestClasses>true</checkTestClasses>
182182
<signature>
183-
<groupId>org.codehaus.mojo.signature</groupId>
184-
<artifactId>java16-sun</artifactId>
185-
<version>1.10</version>
183+
<groupId>com.toasttab.android</groupId>
184+
<artifactId>gummy-bears-api-19</artifactId>
185+
<version>0.6.1</version>
186+
<!-- TODO(cpovirk): In principle, it would make sense to *also* test compatibility with JDK 1.8, since guava-android also has JRE users. -->
186187
</signature>
187188
<ignores>
188-
<!-- Allow requireNonNull: Android desugaring rewrites it (so it's safe for us to use), and it's useful for null checks. Note that this line allows *all* methods from java.util.Objects. That's the best that we can do with the configuration options that Animal Sniffer offers. -->
189-
<ignore>java.util.Objects</ignore>
190-
<!-- Unsafe isn't part of the documented Java 6 API, but it is available.
191-
And in cases where it's not, we have fallbacks. -->
189+
<!-- Unsafe isn't part of the documented Android API, but it is available.
190+
And in cases where it's not, we have fallbacks (except maybe Striped64 (b/307807965)?). -->
192191
<ignore>sun.misc.Unsafe</ignore>
193192
</ignores>
194193
</configuration>

0 commit comments

Comments
 (0)