Skip to content

Commit 0d89d87

Browse files
mkruskal-googlecopybara-github
authored andcommitted
Migrate syntax reflection to new feature-based system.
PiperOrigin-RevId: 516641207
1 parent eb3fdff commit 0d89d87

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

protobuf/compiler/src/google/protobuf/compiler/j2objc/j2objc_field.cc

+1-2
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,7 @@ void FieldGenerator::GenerateStaticRefs(io::Printer *printer) const {
283283
SingleFieldGenerator::SingleFieldGenerator(
284284
const FieldDescriptor *descriptor, uint32_t *numHasBits)
285285
: FieldGenerator(descriptor) {
286-
if (descriptor->containing_oneof() == nullptr ||
287-
descriptor->containing_oneof()->is_synthetic()) {
286+
if (descriptor->real_containing_oneof() == nullptr) {
288287
variables_["has_bit_index"] = SimpleItoa((*numHasBits)++);
289288
}
290289
}

protobuf/compiler/src/google/protobuf/compiler/j2objc/j2objc_message.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ void MessageGenerator::GenerateSource(io::Printer* printer) {
377377
}
378378
for (int i = 0; i < descriptor_->oneof_decl_count(); i++) {
379379
const OneofDescriptor* oneof = descriptor_->oneof_decl(i);
380-
if (oneof->is_synthetic()) {
380+
if (oneof->field_count() == 1) {
381381
field_generators_.get(oneof->field(0)).GenerateDeclaration(printer);
382382
} else {
383383
printer->Print("union {\n");

0 commit comments

Comments
 (0)