PR merge test #2779
Open
PR merge test #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a PowerDNS writer
Co-authored-by: Copilot <[email protected]>
…comments Update configuration mgmt from review comments
Sync from upstream google/nomulus parent
We plan on using this for EPP password resets and registry lock password resets for now.
This avoids potential replication lag issues when requesting info on domains that were just created.
* Remove registrar id from invoice grouping key * Fix formatting issues * Update BillingEventTests
This is just so that we can add an additional layer of security on verification
If contacts are optional, they should be optional in the command too.
The Cloud DNS rest api is now case-sensitive about enum names (must be lower case, counterintuitively).
We can probably improve on this in the future if we want, but there's a lot of boilerplate that we don't need to repeat over and over
This picks up a few changes including aligning the placement of quotes in text blocks with the Google style guide.
Add a new DnsWritersModule for use by the component classes. To override the set of writers installed, we can easily overwrite this file with a private version.
This implements two type of changes: 1. changing the link type for things like the terms of service 2. adding the request URL to each and every link with the "value" field. This is a bit tricky to implement because the links are generated in various places, but we can implement it by adding it to the results after generation. See b/418782147 for more information
It was making the undo nomulus command look like this: )nomulus ...
A future PR will add the actions that save and use this object. That future PR will also require loading RegistrarPoc objects given the registrar ID, hence the change in that class.
Pubapi actions should always use cache, regardless of the config settings on caching. In EppResource.java, the original `loadCached(Iterable<VKey>)` method is renamed to `loadByCacheIfEnabled`. The original `loadCached(Vkey)` method is renamed to `loadByCache` and always uses cache. In EppResourceUtils.java, the original `loadByForeignKeyCached` method is renamed to `loadByForeignKeyByCacheIfEnabled`. A new `loadByForeignKeyByCache` method, which always uses cache. In ForeighKeyUtils.java, the original `loadCached` method is renamed to `loadByCacheIfEnabled`, and a new `loadCached` method is added which always uses cache. Also added a `getContactsFromReplica` method in Registrar, for use by RDAP actions.
Scripts needed by cron jobs wrongly removed by PR 2661. TESTED: in crash.
In RDAP, domain queries are the most common by a factor of like 40,000 so we should optimize these as much as possible. We already have an EPP resource / foreign key cache which does improve performance somewhat but looking at some sample logs, it only cuts the RDAP request times by like 40% (looking at requests for the same domain a few seconds apart). History entries don't change often, so we should cache them to make subsequent queries faster as well. In addition, we're only caching two fields per repo ID (modification time, registrar ID) so we can cache more entries than we can for the EPP resource cache (which stores large objects).
…lot-commit Remove commit from co-pilot due to conflict with google repo requirements
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+186
to
+188
| Boolean isAnyDomainUpdate = | ||
| update.getSection(Section.UPDATE).stream() | ||
| .anyMatch(record -> record.getName().equals(r.getName()) && !isDeleteRecord(record)); |
Check warning
Code scanning / CodeQL
Boxed variable is never null Warning
| .orElse(null); | ||
|
|
||
| // if both keys are found, complete the ZSK rollover | ||
| if (activeZsk != null && inactiveZsk != null) { |
Check warning
Code scanning / CodeQL
Useless null check Warning
| * @return true if the record is a delete record, false otherwise | ||
| */ | ||
| private Boolean isDeleteRecord(Record r) { | ||
| return r.getTTL() == 0 && r.rdataToString().equals(""); |
Check notice
Code scanning / CodeQL
Inefficient empty string test Note
| this.changetype = changetype; | ||
| } | ||
|
|
||
| public List<RecordObject> getRecords() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: do not submit.
This change is