-
Notifications
You must be signed in to change notification settings - Fork 487
tests: Pin python deps #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Pin python deps #2380
Conversation
|
doesn't this defeat the point though, as we're wanting to test transient resolving? This is why some of the other Python tests don't use cassettes |
|
I don't think that's this test, this is for testing scanning artifacts in image scanning, so the transitive resolution is being done by pip, not by osv-scanner. |
|
@G-Rath the test in change is for image scanning but not source scanning |
|
Sure, but it still tests our dealings with external package managers right? I'm not saying this is completely wrong, I'm just checking that has been discussed especially as there is an alternative action we could take (not use cassettes for this particular test) 🙂 |
|
also I just realized the pull request title checker doesn't seem to be running - I think its not running for PRs from forks? ( |
Huh that is weird, I'm sure it was running before for my PRs which have always been forks. |
For this case I think it's fine, I've been wanting to pin the dependencies here for a while, just haven't gotten around to it. The images that we are testing should not be changing over time. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 67.68% 67.68%
=======================================
Files 172 172
Lines 13147 13147
=======================================
Hits 8898 8898
Misses 3551 3551
Partials 698 698 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pin the python dependencies so it doesn't change and break our cassettes