You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the smart_control/environment/environment.py, the Environment class has a parameter step_interval: pd.Timedelta = pd.Timedelta(15, unit="minutes"). This parameter is used to calculate the number of timesteps in the episode:
However, in the smart_control/models/base_building.py file, the BaseBuilding class has a @property def time_step_sec(self) -> float: property, which is used by the Environment class to calculate the steps_per_episode property:
This seems ambiguous to me: if the value of step_interval does not correspond to the same value as time_step_sec, there will be a divergence in the number of steps
Here, do these two parameters indicate the same concept? (In which case we can get rid of the step_interval parameter of the Environment class?)
Or do they indicate different concepts? (In which case the implementation of Environment must be changed?)
The text was updated successfully, but these errors were encountered:
In the
smart_control/environment/environment.py
, theEnvironment
class has a parameterstep_interval: pd.Timedelta = pd.Timedelta(15, unit="minutes")
. This parameter is used to calculate the number of timesteps in the episode:However, in the
smart_control/models/base_building.py
file, theBaseBuilding
class has a@property def time_step_sec(self) -> float:
property, which is used by theEnvironment
class to calculate thesteps_per_episode
property:This seems ambiguous to me: if the value of
step_interval
does not correspond to the same value astime_step_sec
, there will be a divergence in the number of stepsHere, do these two parameters indicate the same concept? (In which case we can get rid of the
step_interval
parameter of theEnvironment
class?)Or do they indicate different concepts? (In which case the implementation of
Environment
must be changed?)The text was updated successfully, but these errors were encountered: