Skip to content

SHADERC_SKIP_INSTALL cmake option broken #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnzupin opened this issue Jul 18, 2024 · 1 comment
Open

SHADERC_SKIP_INSTALL cmake option broken #1435

johnzupin opened this issue Jul 18, 2024 · 1 comment

Comments

@johnzupin
Copy link

Running cmake with the SHADERC_SKIP_INSTALL option will break cmake:

...
**CMake Error: install(EXPORT "glslang-targets" ...) includes target "SPIRV" which requires target "SPIRV-Tools-opt" that is not in any export set.**
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

I think the issue is https://github.com/google/shaderc/blob/main/third_party/CMakeLists.txt#L90:

    set(GLSLANG_ENABLE_INSTALL $<NOT:${SKIP_GLSLANG_INSTALL}>)

I don't believe that "$<NOT" generator expression works during cmake's configure time, only at cmake's generation time.

@wk1093
Copy link

wk1093 commented Apr 12, 2025

#1492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants