Skip to content

[bazel_rule] New DSLX test rule that allows for multiple compare options. #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtdudek opened this issue Jun 5, 2023 · 1 comment
Closed

[bazel_rule] New DSLX test rule that allows for multiple compare options. #1011

mtdudek opened this issue Jun 5, 2023 · 1 comment
Labels
build Related to build flow, build system, or build macros enhancement New feature or request

Comments

@mtdudek
Copy link
Contributor

mtdudek commented Jun 5, 2023 •
edited
Loading

Right now xls_dslx_test allows only for single compare mode.
This forces user to create 2 or more targets, if they want to
test multiple compare options (see #974).

I'm suggesting adding new xls_dslx_multi_test rule(PR #1012).
@mtdudek mtdudek mentioned this issue Jun 5, 2023
Closed
@mtdudek mtdudek moved this to In Progress in Antmicro XLS Jun 5, 2023
@proppy proppy added enhancement New feature or request build Related to build flow, build system, or build macros labels Jun 7, 2023
@proppy
Copy link
Member

proppy commented Apr 3, 2024

Closing following @cdleary suggestion, if this is needed by #1211 it can be implemented as a local https://bazel.build/extending/macros rather than introducing a new rule.

@proppy proppy closed this as completed Apr 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Antmicro XLS Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Related to build flow, build system, or build macros enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@proppy @mtdudek