Use generate statements for multidimensional array updates. #3207
+623
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericastor
reviewed
Oct 16, 2025
xls/codegen/testdata/combinational_generator_test_PrioritySelectOneHot.vtxt
Show resolved
Hide resolved
grebe
requested changes
Oct 16, 2025
xls/codegen/testdata/combinational_generator_test_ArrayUpdate2DUpdateArrayVariableIndex.vtxt
Show resolved
Hide resolved
meheff
force-pushed
the
meheff/10-16-2025-array-update-generate
branch
from
ed1171b to
1423b5a
Compare
|
The failure //xls/jit:jit_channel_queue_test is unrelated and seems to be broken at head at least for github CI. |
|
Would you mind rebasing and re-running rebuild-goldens? That script was missing a bunch of tests it should have included but it has been updated now. |
This significantly reduces the size of the verilog for these operations. Also reduce unnecessary duplication of expressions in some ops.
meheff
force-pushed
the
meheff/10-16-2025-array-update-generate
branch
from
1423b5a to
5d05563
Compare
|
(I missed your earlier comment). Updated and fixed tests. Also fixed the golden file script which was broken in OSS. |
grebe
approved these changes
Oct 29, 2025
|
Add "Reviewing Internally" label? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces the size of the verilog for these operations. Also reduce unnecessary duplication of expressions in some ops, and inline bits typed literals.