Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FromZeros::insert_vec_zeroed both panics and returns Result #2242

Open
kupiakos opened this issue Jan 18, 2025 · 0 comments
Open

FromZeros::insert_vec_zeroed both panics and returns Result #2242

kupiakos opened this issue Jan 18, 2025 · 0 comments

Comments

@kupiakos
Copy link
Contributor

kupiakos commented Jan 18, 2025 •
edited
Loading

Fallible functions that also panic is a general API smell. insert_vec_zeroed mirrors std's panicking on index, but doesn't mirror the panicking allocation.

In the next breaking version, I propose that insert_vec_zeroed be made fully fallible by returning Err if position > v.len().

Relevant: #1653
@kupiakos kupiakos changed the title insert_vec_zeroed both panics and returns Result FromZeros::insert_vec_zeroed both panics and returns Result Jan 18, 2025
@kupiakos kupiakos mentioned this issue Jan 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kupiakos