Skip to content

Commit c279a12

Browse files
committed
skip test and clirr
1 parent 2792761 commit c279a12

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

google-cloud-spanner/clirr-ignored-differences.xml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -709,6 +709,13 @@
709709
<method>boolean isEnableBuiltInMetrics()</method>
710710
</difference>
711711

712+
<!-- Added Built In GRPC Metrics option -->
713+
<difference>
714+
<differenceType>7012</differenceType>
715+
<className>com/google/cloud/spanner/SpannerOptions$SpannerEnvironment</className>
716+
<method>boolean isEnableGRPCBuiltInMetrics()</method>
717+
</difference>
718+
712719
<!-- Added Monitoring host option -->
713720
<difference>
714721
<differenceType>7012</differenceType>
@@ -765,7 +772,7 @@
765772
<className>com/google/cloud/spanner/connection/Connection</className>
766773
<method>boolean isKeepTransactionAlive()</method>
767774
</difference>
768-
775+
769776
<!-- Automatic DML batching -->
770777
<difference>
771778
<differenceType>7012</differenceType>
@@ -797,7 +804,7 @@
797804
<className>com/google/cloud/spanner/connection/Connection</className>
798805
<method>boolean isAutoBatchDmlUpdateCountVerification()</method>
799806
</difference>
800-
807+
801808
<!-- Retry DML as Partitioned DML -->
802809
<difference>
803810
<differenceType>7012</differenceType>
@@ -821,7 +828,7 @@
821828
<className>com/google/cloud/spanner/connection/Connection</className>
822829
<method>java.lang.Object runTransaction(com.google.cloud.spanner.connection.Connection$TransactionCallable)</method>
823830
</difference>
824-
831+
825832
<!-- Added experimental host option -->
826833
<difference>
827834
<differenceType>7012</differenceType>
@@ -861,5 +868,5 @@
861868
<className>com/google/cloud/spanner/connection/ConnectionOptions</className>
862869
<field>VALID_PROPERTIES</field>
863870
</difference>
864-
871+
865872
</differences>

google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBuiltInMetricsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ public class ITBuiltInMetricsTest {
6161

6262
@BeforeClass
6363
public static void setUp() throws IOException {
64+
assumeFalse("This test requires credentials", EmulatorSpannerHelper.isUsingEmulator());
6465
metricClient = MetricServiceClient.create();
6566
// Enable BuiltinMetrics when the metrics are GA'ed
6667
db = env.getTestHelper().createTestDatabase();
@@ -76,7 +77,6 @@ public void tearDown() {
7677

7778
@Test
7879
public void testBuiltinMetricsWithDefaultOTEL() throws Exception {
79-
assumeFalse("This test requires credentials", EmulatorSpannerHelper.isUsingEmulator());
8080
// This stopwatch is used for to limit fetching of metric data in verifyMetrics
8181
Stopwatch metricsPollingStopwatch = Stopwatch.createStarted();
8282
Instant start = Instant.now().minus(Duration.ofMinutes(2));

0 commit comments

Comments
 (0)