-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find module 'core-js/modules/es.string.replace.js' #1182
Comments
If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.@hcancelik Thank you for opening this issue. 🙏
This is an automated message, feel free to ignore. |
Looking closely at the issue, this is related to the URL signature package. There is an open ticket here, so I'm closing this one. |
Shouldn't it have pinned dependencies to avoid issues like that going forward? |
Confirming, cross-posting, and summarizing some workarounds from the googlemaps/js-url-signature#528 issue thread, npm users can override the upstream js-url-signature version to the 1.0.32 version:
Similarly it appears that users of other package managers (presumably pnpm or yarn) can use the following, but I have not personally confirmed:
Alternately, you could add "core-js" explicitly as a dev dependency (also confirmed works in our use case):
That said, these are essentially just temporary workarounds already suggested by others in the googlemaps/js-url-signature#528 issue thread that I am cross-posting here for convenience and confirming worked for my team -- but my own team's actual plan is to just wait a bit for a fix, so that we don't have to remember to pull these out when js-url-signature is presumably updated. |
same for me |
Currently getting the following error from this library
Cannot find module 'core-js/modules/es.string.replace.js' from 'node_modules/@googlemaps/url-signature/dist/index.umd.js'
Environment details
Code example
Stack trace
Thanks!
The text was updated successfully, but these errors were encountered: