1.0.33 release requires `core-js` but states no dependency

[iamcdonald]

We're currently using @googlemaps/google-maps-services-js which has the following dependency on this module

{
  "dependencies": {
    "@googlemaps/url-signature": "^1.0.4",
    ...
  }
}

Unfortunately it would appear that changes to the build process for this module have manifested in the latest release (1.0.33) dist/index.umd.js requiring imports from core-js.

We're currently working around the issue by using npm overrides but I was wondering if it was intentional that core-js hadn't been added to dependencies or peerDependencies for this module.

[wangela]

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@iamcdonald Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

• Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
• Open a support case - Get 1:1 support in Cloud Console.
• Discord - chat with other developers
• StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

[hcancelik]

core-js is actually listed on the devDependencies but we are also getting the same issue.

Cannot find module 'core-js/modules/es.string.replace.js' from 'node_modules/@googlemaps/url-signature/dist/index.umd.js'

const { Client } = require("@googlemaps/google-maps-services-js");

 Require stack:
        node_modules/@googlemaps/url-signature/dist/index.umd.js
        node_modules/@googlemaps/google-maps-services-js/dist/serialize.js
        node_modules/@googlemaps/google-maps-services-js/dist/directions.js
        node_modules/@googlemaps/google-maps-services-js/dist/client.js
        node_modules/@googlemaps/google-maps-services-js/dist/geolocate.js
        node_modules/@googlemaps/google-maps-services-js/dist/index.js

[segovia-no]

Same issue here, using the @googlemaps/google-maps-services-js dependency in our projects results into an unmet dependency within this @googlemaps/url-signature repo, output is the same as the comment above.

[victororozco]

Same issue here, we fixed it temporarily using:

"resolutions": {
  "@googlemaps/url-signature": "1.0.32"
},

[vitorsilvalima]

have the same issue here

2024-04-01T20:08:31.857Z	undefined	ERROR	Uncaught Exception 	{
    "errorType": "Runtime.ImportModuleError",
    "errorMessage": "Error: Cannot find module 'core-js/modules/es.string.replace.js'\nRequire stack:\n- /var/task/node_modules/@googlemaps/url-signature/dist/index.umd.js\n- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/serialize.js\n- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/directions.js\n- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/client.js\n- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/geolocate.js\n- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/index.js\n- /var/task/src/features/menu/handlers/index.js\n- /var/runtime/index.mjs",
    "stack": [
        "Runtime.ImportModuleError: Error: Cannot find module 'core-js/modules/es.string.replace.js'",
        "Require stack:",
        "- /var/task/node_modules/@googlemaps/url-signature/dist/index.umd.js",
        "- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/serialize.js",
        "- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/directions.js",
        "- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/client.js",
        "- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/geolocate.js",
        "- /var/task/node_modules/@googlemaps/google-maps-services-js/dist/index.js",
        "- /var/task/src/features/menu/handlers/index.js",
        "- /var/runtime/index.mjs",
        "    at _loadUserApp (file:///var/runtime/index.mjs:1087:17)",
        "    at async UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1119:21)",
        "    at async start (file:///var/runtime/index.mjs:1282:23)",
        "    at async file:///var/runtime/index.mjs:1288:1"
    ]
}

[viniciusreiss]

same problem here

[reinel-panita]

Same problem for me

[Politta]

Same issue for us:

Apr  2 02:00:57 ip-172-31-28-96 web[3162]: Error: Cannot find module 'core-js/modules/es.string.replace.js'
.
.
.
Apr  2 02:00:57 ip-172-31-28-96 web[3162]:    at Module._load (node:internal/modules/cjs/loader:960:12) {
Apr  2 02:00:57 ip-172-31-28-96 web[3162]:  code: 'MODULE_NOT_FOUND',
Apr  2 02:00:57 ip-172-31-28-96 web[3162]:  requireStack: [
Apr  2 02:00:57 ip-172-31-28-96 web[3162]:    '/var/app/current/node_modules/@googlemaps/url-signature/dist/index.umd.js',

[chrysanthosDsq]

Same issue for us

[zhiwei-homage]

Same issue for us

[ogurashi]

same issue here

[chargome]

Same issue here, we fixed it temporarily using:

"resolutions": {
  "@googlemaps/url-signature": "1.0.32"
},

for npm users the equivalent is

"overrides": {
  "@googlemaps/url-signature": "1.0.32"
},