Skip to content

react-notification-system as a peer dependency #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ahaider48 opened this issue Oct 25, 2017 · 2 comments
Open

react-notification-system as a peer dependency #54

ahaider48 opened this issue Oct 25, 2017 · 2 comments

Comments

@ahaider48
Copy link

Currently, your installation instructions says to install both react-notification-system and react-notification-system-redux. However, you included react-notification-system as a dependency in your package.json as well. Is there a reason for that?

shouldn't it be moved to peerDependencies section instead?
@gor181
Copy link
Owner

gor181 commented Oct 29, 2017

If it ain't a dependency you won't be able to run examples locally or run tests? afaik.
Let me know if you managed to get it working as peer dependency in those cases.
Most likely we could move it to dev-dependencies.

@Oskku
Copy link
Contributor

Oskku commented Nov 2, 2022

Can you please add react 17 and 18 to it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gor181 @ahaider48 @Oskku