Fix: increase buffer size for knowledge ingest processFix #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
requested review from
g-linville,
ryanhopperlowe,
thedadams and
tylerslaton
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
increase-buffer-size
branch
from
d8586c2 to
d6cab0c
Compare
ryanhopperlowe
approved these changes
Sep 20, 2024
g-linville
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since knowledge tool will produce more status log now, we need to increase the buffer size so that it doesn't error out when ingesting a big set of documents. #491
Note: we could do it based on node stream, but not going to spend too much effort on this fix.