fix: return error if build tool fails

thedadams · thedadams · commit f15e7fb8d415 · 2024-10-18T10:39:23.000-04:00
A change was made to return an error if running a code-based tool fails.
This should also happen if building the tool fails.

Signed-off-by: Donnie Adams &lt;donnie@acorn.io&gt;
diff --git a/pkg/engine/cmd.go b/pkg/engine/cmd.go
@@ -124,10 +124,10 @@ func (e *Engine) runCommand(ctx Context, tool types.Tool, input string, toolCate
 	}
 	cmd, stop, err := e.newCommand(ctx.Ctx, extraEnv, tool, input, true)
 	if err != nil {
-		if toolCategory == NoCategory {
+		if toolCategory == NoCategory && ctx.Parent != nil {
 			return fmt.Sprintf("ERROR: got (%v) while parsing command", err), nil
 		}
-		return "", err
+		return "", fmt.Errorf("got (%v) while parsing command", err)
 	}
 	defer stop()
 

Original file line number	Diff line number	Diff line change
`@@ -124,10 +124,10 @@ func (e *Engine) runCommand(ctx Context, tool types.Tool, input string, toolCate`
`124`	`124`	`}`
`125`	`125`	`cmd, stop, err := e.newCommand(ctx.Ctx, extraEnv, tool, input, true)`
`126`	`126`	`if err != nil {`
`127`		`- if toolCategory == NoCategory {`
	`127`	`+ if toolCategory == NoCategory && ctx.Parent != nil {`
`128`	`128`	`return fmt.Sprintf("ERROR: got (%v) while parsing command", err), nil`
`129`	`129`	`}`
`130`		`- return "", err`
	`130`	`+ return "", fmt.Errorf("got (%v) while parsing command", err)`
`131`	`131`	`}`
`132`	`132`	`defer stop()`
`133`	`133`