Roll types 0.1.52 -> 0.1.59 (#4302)

Author: kainino0x

package-lock.json

@@ -50,7 +50,7 @@
     "@types/w3c-image-capture": "^1.0.10",
     "@typescript-eslint/eslint-plugin": "^6.9.1",
     "@typescript-eslint/parser": "^6.9.1",
-    "@webgpu/types": "^0.1.52",
+    "@webgpu/types": "^0.1.59",
     "ansi-colors": "4.1.3",
     "babel-plugin-add-header-comment": "^1.0.3",
     "babel-plugin-const-enum": "^1.2.0",

package.json

@@ -2,7 +2,7 @@ import { ResolveType, ZipKeysWithValues } from './types.js';
 
 export type valueof<K> = K[keyof K];
 
-export function keysOf<T extends string>(obj: { [k in T]: unknown }): readonly T[] {
+export function keysOf<T extends string>(obj: { [k in T]?: unknown }): readonly T[] {
   return Object.keys(obj) as unknown[] as T[];
 }
 

src/common/util/data_tables.ts

@@ -138,13 +138,6 @@ different orders to make sure that they are consistent regardless of the access
     }
   });
 
-// This can be removed once 'subgroups' lands.
-// See https://github.com/gpuweb/gpuweb/pull/4963
-interface SubgroupProperties extends GPUAdapterInfo {
-  subgroupMinSize?: number;
-  subgroupMaxSize?: number;
-}
-
 const kSubgroupMinSizeBound = 4;
 const kSubgroupMaxSizeBound = 128;
 
@@ -161,7 +154,7 @@ If they exist, they must both exist and be powers of two, and
     const gpu = getGPU(t.rec);
     const adapter = await gpu.requestAdapter();
     assert(adapter !== null);
-    const { subgroupMinSize, subgroupMaxSize } = adapter.info as SubgroupProperties;
+    const { subgroupMinSize, subgroupMaxSize } = adapter.info;
     // Once 'subgroups' lands, the properties should be defined with default values 4 and 128
     // when adapter does not support the feature.
     // https://github.com/gpuweb/gpuweb/pull/4963

src/resources/cache/hashes.json

@@ -905,6 +905,8 @@ export const kFeatureNameInfo: {
   'float32-blendable':                  {},
   'clip-distances':                     {},
   'dual-source-blending':               {},
+  'subgroups':                          {},
+  'core-features-and-limits':           {},
 };
 /** List of all GPUFeatureName values. */
 export const kFeatureNames = keysOf(kFeatureNameInfo);

src/webgpu/api/operation/adapter/info.spec.ts

@@ -19,9 +19,11 @@ export class IDLTest extends Fixture {
   /**
    * Asserts that a member of an IDL interface has the expected value.
    */
-  assertMember(act: UnknownObject, exp: UnknownObject, key: string) {
+  assertMember(act: object, exp: object, key: string) {
     assert(key in act, () => `Expected key ${key} missing`);
-    assert(act[key] === exp[key], () => `Value of [${key}] was ${act[key]}, expected ${exp[key]}`);
+    const actValue = (act as UnknownObject)[key];
+    const expValue = (exp as UnknownObject)[key];
+    assert(actValue === expValue, () => `Value of [${key}] was ${actValue}, expected ${expValue}`);
   }
 
   /**
@@ -30,7 +32,7 @@ export class IDLTest extends Fixture {
    * MAINTENANCE_TODO: add a way to check for the types of keys with unknown values, like methods and attributes
    * MAINTENANCE_TODO: handle extensions
    */
-  assertMemberCount(act: UnknownObject, exp: UnknownObject) {
+  assertMemberCount(act: object, exp: object) {
     const expKeys = Object.keys(exp);
     const actKeys = Object.keys(act);
     assert(

src/webgpu/capability_info.ts

@@ -2895,12 +2895,9 @@ function getEffectiveViewDimension(
   t: GPUTest,
   descriptor: Omit<GPUTextureDescriptor, 'format' | 'usage'>
 ): GPUTextureViewDimension {
-  const { textureBindingViewDimension } = descriptor as unknown as {
-    textureBindingViewDimension?: GPUTextureViewDimension;
-  };
   const size = reifyExtent3D(descriptor.size);
   return effectiveViewDimensionForDimension(
-    textureBindingViewDimension,
+    descriptor.textureBindingViewDimension,
     descriptor.dimension,
     size.depthOrArrayLayers
   );

src/webgpu/idl/idl_test.ts

@@ -207,7 +207,8 @@ export function defaultViewDimensionsForTexture(textureDescriptor: Readonly<GPUT
  */
 export function reifyTextureDescriptor(
   desc: Readonly<GPUTextureDescriptor>
-): Required<Omit<GPUTextureDescriptor, 'label' | 'viewFormats'>> {
+): GPUTextureDescriptor &
+  Required<Omit<GPUTextureDescriptor, 'label' | 'viewFormats' | 'textureBindingViewDimension'>> {
   return { dimension: '2d' as const, mipLevelCount: 1, sampleCount: 1, ...desc };
 }