Skip to content

Commit 951d7a6

Browse files
committed
address comments
1 parent f574a63 commit 951d7a6

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/webgpu/gpu_test.ts

+10-9
Original file line numberDiff line numberDiff line change
@@ -528,18 +528,19 @@ export class GPUTestBase extends Fixture<GPUTestSubcaseBatchState> {
528528
*/
529529
skipIfTextureFormatNotSupported(...formats: (GPUTextureFormat | undefined)[]) {
530530
for (const format of formats) {
531-
if (format) {
531+
if (!format) {
532+
continue;
533+
}
534+
if (format === 'bgra8unorm-srgb') {
532535
if (isCompatibilityDevice(this.device)) {
533-
if (format === 'bgra8unorm-srgb') {
534-
this.skip(`texture format '${format} is not supported`);
535-
}
536+
this.skip(`texture format '${format}' is not supported`);
536537
}
537-
const feature = getRequiredFeatureForTextureFormat(format);
538-
this.skipIf(
539-
!!feature && !this.device.features.has(feature),
540-
`texture format '${format}' requires feature: '${feature}`
541-
);
542538
}
539+
const feature = getRequiredFeatureForTextureFormat(format);
540+
this.skipIf(
541+
!!feature && !this.device.features.has(feature),
542+
`texture format '${format}' requires feature: '${feature}`
543+
);
543544
}
544545
}
545546

0 commit comments

Comments
 (0)