Skip to content

workgroupUniformLoad: test pointer-to-atomic variant #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dneto0 opened this issue Apr 10, 2025 · 7 comments
Open

workgroupUniformLoad: test pointer-to-atomic variant #4341

dneto0 opened this issue Apr 10, 2025 · 7 comments
Labels

Comments

@dneto0
Copy link
Contributor

dneto0 commented Apr 10, 2025

See gpuweb/gpuweb#5141

This requires basic testing:

  • that all invocations get the same value from the atomic
  • that it passes uniformity checks (the load is treated as uniform)

Ideally we would also modify the memory model tests to stress test the case. (That would likely be on me, as I'm the maintainer of those tests)

@dneto0 dneto0 added the wgsl label Apr 10, 2025
@dj2
Copy link
Member

dj2 commented Apr 10, 2025

I think this is done in d3ac578 already?

@dneto0
Copy link
Contributor Author

dneto0 commented Apr 10, 2025

#4332
oh, I didn't now about that!

It's a good start.

  • I'd also like to see loading from an atomic inside a larger workgroup variable. The Add tests for workgroupUniformLoad overload #4332 only tests the case where the atomic is the whole store type to the variable.
  • extend uniformity tests (my second point above).

@dneto0
Copy link
Contributor Author

dneto0 commented Apr 10, 2025

@beaufortfrancois FYI in case you wanted to pursue this further

@beaufortfrancois
Copy link
Collaborator

@dneto0 I'll let you handle it if that's okay. If not, I can start working on it.

@beaufortfrancois
Copy link
Collaborator

beaufortfrancois commented Apr 11, 2025

@dneto0 I've started #4347 and #4348

@beaufortfrancois
Copy link
Collaborator

Let me know if we can close this issue or if we shall wait for @dneto0 to modify the memory model tests as well.

@dneto0
Copy link
Contributor Author

dneto0 commented Apr 24, 2025

Please keep this open for the memory model stress tests. Otherwise I'd open a new one for the stress tests... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants