Skip to content

op: Test camera capture using copyExternalImageToTexture #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kainino0x opened this issue Apr 19, 2025 · 0 comments
Open

op: Test camera capture using copyExternalImageToTexture #4364

kainino0x opened this issue Apr 19, 2025 · 0 comments

Comments

@kainino0x
Copy link
Collaborator

Currently we have camera capture tests for importExternalTexture but not copyExternalImageToTexture.

@kainino0x kainino0x changed the title Test camera capture using copyExternalImageToTexture op: Test camera capture using copyExternalImageToTexture Apr 19, 2025
kainino0x added a commit that referenced this issue Apr 23, 2025
- Don't use fallback paths in camera capture; instead, have the test pick the exact path it's using, and parameterize over it. Test two paths: VideoFrame from MediaStreamTrackProcessor, and the old-fashioned HTMLVideoElement.
- Work around an issue where Chrome (at least on Mac) shows blank frames for a while after initializing the camera.
- I happened to notice that requesting different width/height from the camera is broken in Chrome in several ways, so added cases for that.
- Added a TODO for copyExternalImageToTexture from camera

These tests only worked in Chrome, and even then they were buggy (usually running the test on a blank first frame). Now, the HTMLVideoElement tests work in Safari.

Test failures are as follows, on an M1 Mac:
- Chrome: https://crbug.com/411656657
  - HTMLVideoElement passes some cases, but fails when a requested size is passed to getUserMedia().
  - VideoFrame fails due to incorrect color management (regardless of dstColorSpace).
- Safari:
  - HTMLVideoElement fails due to incorrect color management (regardless of dstColorSpace).
  - VideoFrame is skipped.
- Firefox: doesn't yet implement importExternalTexture.

Issue: fixes #4363, cc #4364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant