Skip to content

Commit 01b1547

Browse files
committed
Address review comments.
1 parent 329b209 commit 01b1547

File tree

1 file changed

+7
-22
lines changed

1 file changed

+7
-22
lines changed

src/test/groovy/org/gradle/android/TaskAvoidanceTest.groovy

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,20 @@ import spock.lang.Unroll
66

77
class TaskAvoidanceTest extends AbstractTest {
88
@Unroll
9-
def "tasks are avoided with #gradleVersion and Android plugin #androidVersion"() {
9+
def "Source Tasks are avoided with #gradleVersion and Android plugin #androidVersion"() {
1010
assert gradleVersion instanceof GradleVersion
1111
assert androidVersion instanceof VersionNumber
1212

13-
println "> Using Android plugin $androidVersion"
14-
println "> Running with $gradleVersion"
15-
13+
given:
1614
SimpleAndroidApp.builder(temporaryFolder.root, cacheDir)
1715
.withAndroidVersion(androidVersion)
18-
.withKotlinDisabled()
16+
.withKotlinDisabled()
1917
.build()
2018
.writeProject()
2119

22-
def originalSettings = file('build.gradle').text
23-
file('build.gradle').text = """
24-
${originalSettings}
25-
20+
file('build.gradle') << """
2621
allprojects {
27-
tasks.configureEach {
22+
tasks.withType(SourceTask).configureEach {
2823
println "configuring \$it"
2924
}
3025
}
@@ -33,21 +28,11 @@ class TaskAvoidanceTest extends AbstractTest {
3328
when:
3429
def result = withGradleVersion(gradleVersion.version)
3530
.withProjectDir(temporaryFolder.root)
36-
.withArguments("help")
31+
.withArguments('help')
3732
.build()
3833

3934
then:
40-
result.output.contains("configuring task ':help'")
41-
!result.output.contains("configuring task ':app:compileDebugJavaWithJavac'")
42-
!result.output.contains("configuring task ':app:compileDebugAndroidTestJavaWithJavac'")
43-
!result.output.contains("configuring task ':app:compileDebugUnitTestJavaWithJavac'")
44-
!result.output.contains("configuring task ':app:compileReleaseJavaWithJavac'")
45-
!result.output.contains("configuring task ':app:compileReleaseUnitTestJavaWithJavac'")
46-
!result.output.contains("configuring task ':library:compileDebugJavaWithJavac'")
47-
!result.output.contains("configuring task ':library:compileDebugAndroidTestJavaWithJavac'")
48-
!result.output.contains("configuring task ':library:compileDebugUnitTestJavaWithJavac'")
49-
!result.output.contains("configuring task ':library:compileReleaseJavaWithJavac'")
50-
!result.output.contains("configuring task ':library:compileReleaseUnitTestJavaWithJavac'")
35+
!result.output.contains("configuring")
5136

5237
where:
5338
[androidVersion, gradleVersion] << Versions.SUPPORTED_VERSIONS_MATRIX.entries().collect { [it.key, it.value] }

0 commit comments

Comments
 (0)