Skip to content

Commit 205da69

Browse files
authored
Merge pull request #566 from gradle/gk/ptsImprovements
PTS improvements
2 parents e781902 + 7d2bc51 commit 205da69

File tree

4 files changed

+31
-9
lines changed

4 files changed

+31
-9
lines changed

.github/workflows/build-verification.yml

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches: [ main, citest ]
66
pull_request:
7-
branches: [ main ]
87
workflow_dispatch:
98

109
jobs:
@@ -16,7 +15,7 @@ jobs:
1615
- id: setup-matrix
1716
run: echo "matrix=$(jq -cM '.supportedVersions | keys' src/main/resources/versions.json | sed -e 's/\./_/g' -e 's/-/_/g')" >> $GITHUB_OUTPUT
1817
- name: debug
19-
run: echo ${{ steps.setup-matrix.outputs.matrix }}
18+
run: echo "matrix=${{ steps.setup-matrix.outputs.matrix }}"
2019
outputs:
2120
matrix: ${{ steps.setup-matrix.outputs.matrix }}
2221

@@ -48,10 +47,15 @@ jobs:
4847
- name: Set up Gradle
4948
uses: gradle/gradle-build-action@v2
5049
- name: Run unit tests
51-
run: ./gradlew test -x signPluginMavenPublication -x signAndroidCacheFixPluginPluginMarkerMavenPublication -Porg.gradle.java.installations.auto-download=false
50+
run: >-
51+
./gradlew test
52+
-x signPluginMavenPublication
53+
-x signAndroidCacheFixPluginPluginMarkerMavenPublication
54+
-Porg.gradle.java.installations.auto-download=false
55+
-Dpts.mode=$PTS_MODE
5256
env:
5357
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
54-
ORG_GRADLE_PROJECT_isPTSEnabled: ${{ github.ref_name != 'main' }}
58+
PTS_MODE: "${{ github.ref_name == 'main' && 'REMAINING_TESTS' || 'RELEVANT_TESTS' }}"
5559

5660
android_version_tests:
5761
name: Android version tests
@@ -99,7 +103,12 @@ jobs:
99103
- name: Set up Gradle
100104
uses: gradle/gradle-build-action@v2
101105
- name: Run integration tests
102-
run: ./gradlew testAndroid${{ matrix.versions }} -x signPluginMavenPublication -x signAndroidCacheFixPluginPluginMarkerMavenPublication -Porg.gradle.java.installations.auto-download=false
106+
run: >-
107+
./gradlew testAndroid${{ matrix.versions }}
108+
-x signPluginMavenPublication
109+
-x signAndroidCacheFixPluginPluginMarkerMavenPublication
110+
-Porg.gradle.java.installations.auto-download=false
111+
-Dpts.mode=$PTS_MODE
103112
env:
104113
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_SOLUTIONS_ACCESS_TOKEN }}
105-
ORG_GRADLE_PROJECT_isPTSEnabled: ${{ github.ref_name != 'main' }}
114+
PTS_MODE: "${{ github.ref_name == 'main' && 'REMAINING_TESTS' || 'RELEVANT_TESTS' }}"

build.gradle.kts

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
import com.gradle.enterprise.gradleplugin.testretry.retry
2+
import com.gradle.enterprise.gradleplugin.testselection.PredictiveTestSelectionProfile.FAST
3+
import com.gradle.enterprise.gradleplugin.testselection.PredictiveTestSelectionProfile.CONSERVATIVE
4+
import com.gradle.enterprise.gradleplugin.testselection.PredictiveTestSelectionProfile.STANDARD
25
import groovy.json.JsonSlurper
36

47
plugins {
@@ -113,7 +116,13 @@ tasks.withType<Test>().configureEach {
113116
}
114117

115118
predictiveSelection {
116-
enabled = providers.gradleProperty("isPTSEnabled").map { it != "false" }.orElse(false)
119+
enabled = providers.gradleProperty("isPTSEnabled").map { it != "false" }.orElse(true)
120+
}
121+
}
122+
123+
tasks.test {
124+
predictiveSelection {
125+
profile = STANDARD
117126
}
118127
}
119128

@@ -135,6 +144,10 @@ getSupportedVersions().keys.forEach { androidVersion ->
135144
languageVersion = JavaLanguageVersion.of(17)
136145
}
137146
}
147+
148+
predictiveSelection {
149+
profile = FAST
150+
}
138151
}
139152

140153
tasks.check {

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ org.gradle.configuration-cache=true
44
org.gradle.jvmargs=-Duser.language=en -Duser.country=US -Dfile.encoding=UTF-8
55
org.gradle.kotlin.dsl.allWarningsAsErrors=true
66

7-
isPTSEnabled=false
7+
isPTSEnabled=true

release/changes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
- [NEW] Run tests against AGP 8.3.0-alpha01
22
- [NEW] Run tests against AGP 8.2.0-beta01
3-
- [NEW] Run tests against AGP 8.1.1
3+
- [NEW] Run tests against AGP 8.1.1

0 commit comments

Comments
 (0)