Skip to content

Commit 6006b09

Browse files
authored
Merge pull request #63 from gradle/lptr/support-android-3.1.2
Support Android 3.1.2
2 parents fcaa9d3 + c9bc808 commit 6006b09

File tree

5 files changed

+17
-13
lines changed

5 files changed

+17
-13
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Some Android plugin versions have issues with Gradle's build cache feature. When applied to an Android project this plugin applies workarounds for these issues based on the Android plugin and Gradle versions.
66

77
* Supported Gradle versions: 4.1+
8-
* Supported Android versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0-alpha01
8+
* Supported Android versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.1.2, 3.2.0-alpha01
99

1010
**Note:** With Android 3.1.x and 3.2.x the cache-fix plugin is only required if you are using Android's data binding feature.
1111

build.gradle

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ version = ["git", "describe", "--match", "[0-9]*", "--dirty"].execute().text.tri
2222

2323
// Maps supported Android plugin versions to the versions of Gradle that support it
2424
def supportedVersions = [
25-
"3.2.0-alpha01": ["4.5.1", "4.6"],
26-
"3.1.1": ["4.4.1", "4.5.1", "4.6"],
27-
"3.1.0": ["4.4.1", "4.5.1", "4.6"],
28-
"3.0.0": ["4.1", "4.2.1", "4.3.1", "4.4.1", "4.5.1", "4.6"],
29-
"3.0.1": ["4.1", "4.2.1", "4.3.1", "4.4.1", "4.5.1", "4.6"],
25+
"3.2.0-alpha01": ["4.5.1", "4.6", "4.7"],
26+
"3.1.2": ["4.4.1", "4.5.1", "4.6", "4.7"],
27+
"3.1.1": ["4.4.1"],
28+
"3.1.0": ["4.4.1"],
29+
"3.0.1": ["4.1", "4.2.1", "4.3.1", "4.4.1", "4.5.1", "4.6", "4.7"],
30+
"3.0.0": ["4.1"],
3031
]
3132

3233
repositories {

src/main/groovy/org/gradle/android/AndroidCacheFixPlugin.groovy

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
9292
/**
9393
* Fix {@link org.gradle.api.tasks.compile.CompileOptions#getBootClasspath()} introducing relocatability problems for {@link AndroidJavaCompile}.
9494
*/
95-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha06", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68392933")
95+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha06", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68392933")
9696
static class AndroidJavaCompile_BootClasspath_Workaround implements Workaround {
9797
@CompileStatic(TypeCheckingMode.SKIP)
9898
@Override
@@ -118,7 +118,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
118118
/**
119119
* Filter the Java annotation processor output folder from compiler arguments to avoid absolute path.
120120
*/
121-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha06", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68391973")
121+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha06", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68391973")
122122
static class AndroidJavaCompile_AnnotationProcessorSource_Workaround implements Workaround {
123123
@Override
124124
void apply(WorkaroundContext context) {
@@ -129,7 +129,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
129129
/**
130130
* Override path sensitivity for {@link AndroidJavaCompile#getProcessorListFile()} to {@link PathSensitivity#NONE}.
131131
*/
132-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha01", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68759178")
132+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha01", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68759178")
133133
static class AndroidJavaCompile_ProcessorListFile_Workaround implements Workaround {
134134
@CompileStatic(TypeCheckingMode.SKIP)
135135
@Override
@@ -254,7 +254,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
254254
/**
255255
* Override path sensitivity for {@link ExtractAnnotations#getSource()} to {@link PathSensitivity#RELATIVE}.
256256
*/
257-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha01", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68759476")
257+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha01", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68759476")
258258
static class ExtractAnnotations_Source_Workaround implements Workaround {
259259
@CompileStatic(TypeCheckingMode.SKIP)
260260
@Override
@@ -284,7 +284,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
284284
/**
285285
* Fix {@link IncrementalTask#getCombinedInput()} and {@link StreamBasedTask#getCombinedInput()} relocatability.
286286
*/
287-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha04", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68771542")
287+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha04", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68771542")
288288
static class CombinedInput_Workaround implements Workaround {
289289
@CompileStatic(TypeCheckingMode.SKIP)
290290
@Override
@@ -316,7 +316,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
316316
/**
317317
* {@link ProcessAndroidResources#getMergeBlameLogFolder()} shouldn't be an {@literal @}{@link org.gradle.api.tasks.Input}.
318318
*/
319-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha02", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68385486")
319+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.0.1", "3.1.0-alpha02", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68385486")
320320
static class ProcessAndroidResources_MergeBlameLogFolder_Workaround implements Workaround {
321321
@CompileStatic(TypeCheckingMode.SKIP)
322322
@Override
@@ -331,7 +331,7 @@ class AndroidCacheFixPlugin implements Plugin<Project> {
331331
/**
332332
* {@link com.android.build.gradle.internal.tasks.CheckManifest#getManifest()} should not be an {@literal @}{@link org.gradle.api.tasks.Input}.
333333
*/
334-
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha05", "3.1.1", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68772035")
334+
@AndroidIssue(introducedIn = "3.0.0", fixedIn = ["3.1.0-alpha05", "3.1.1", "3.1.2", "3.2.0-alpha01"], link = "https://issuetracker.google.com/issues/68772035")
335335
static class CheckManifest_Manifest_Workaround implements Workaround {
336336
@CompileStatic(TypeCheckingMode.SKIP)
337337
@Override

src/test/groovy/org/gradle/android/PluginApplicationTest.groovy

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ class PluginApplicationTest extends AbstractTest {
5050
true | false | "3.1.0"
5151
false | true | "3.1.1"
5252
true | false | "3.1.1"
53+
false | true | "3.1.2"
54+
true | false | "3.1.2"
5355
false | true | "3.2.0-alpha01"
5456
true | false | "3.2.0-alpha01"
5557
description = warns ? "warn" : "not warn"

src/test/groovy/org/gradle/android/WorkaroundTest.groovy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ class WorkaroundTest extends Specification {
3232
"3.1.0-rc03" | ["DataBindingDependencyArtifacts"]
3333
"3.1.0" | ["DataBindingDependencyArtifacts"]
3434
"3.1.1" | ["DataBindingDependencyArtifacts"]
35+
"3.1.2" | ["DataBindingDependencyArtifacts"]
3536
"3.2.0-alpha01" | ["DataBindingDependencyArtifacts"]
3637
}
3738
}

0 commit comments

Comments
 (0)