Skip to content

Commit c627d84

Browse files
Use ExtractMetric for name parsing in aliasByMetric and sumSeriesWithWildcards (#89)
Use extractMetric method for name parsing in aliasByMetric and sumSeriesWithWildcards
1 parent a418fbd commit c627d84

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

expr/functions/aliasByMetric/function.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55

66
"github.com/grafana/carbonapi/expr/helper"
7+
"github.com/grafana/carbonapi/expr/helper/metric"
78
"github.com/grafana/carbonapi/expr/interfaces"
89
"github.com/grafana/carbonapi/expr/types"
910
"github.com/grafana/carbonapi/pkg/parser"
@@ -30,7 +31,7 @@ func New(configFile string) []interfaces.FunctionMetadata {
3031

3132
func (f *aliasByMetric) Do(ctx context.Context, e parser.Expr, from, until int64, values map[parser.MetricRequest][]*types.MetricData) ([]*types.MetricData, error) {
3233
return helper.ForEachSeriesDo1(ctx, e, from, until, values, func(a *types.MetricData) *types.MetricData {
33-
metric := a.Tags["name"]
34+
metric := metric.ExtractMetric(a.Name)
3435
part := strings.Split(metric, ".")
3536
name := part[len(part)-1]
3637
ret := a.CopyName(name)

expr/functions/sumSeriesWithWildcards/function.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package sumSeriesWithWildcards
22

33
import (
44
"context"
5+
"github.com/grafana/carbonapi/expr/helper/metric"
56
"math"
67
"strings"
78

@@ -46,7 +47,7 @@ func (f *sumSeriesWithWildcards) Do(ctx context.Context, e parser.Expr, from, un
4647
groups := make(map[string][]*types.MetricData)
4748

4849
for _, a := range args {
49-
metric := a.Tags["name"]
50+
metric := metric.ExtractMetric(a.Name)
5051
nodes := strings.Split(metric, ".")
5152
s := make([]string, 0, len(nodes))
5253
// Yes, this is O(n^2), but len(nodes) < 10 and len(fields) < 3

0 commit comments

Comments
 (0)