Skip to content

Commit b60591f

Browse files
committed
fix(helm): do not mark loki.storage.bucketNames.chunks as required, if minio is used.
Signed-off-by: Jan-Otto Kröpke <[email protected]>
1 parent a2c4ea6 commit b60591f

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

production/helm/loki/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Entries should include a reference to the pull request that introduced the chang
1313

1414
## Unreleased
1515

16+
- [BUGFIX] Do not mark loki.storage.bucketNames.chunks as required, if minio is used. [#19871](https://github.com/grafana/loki/pull/19871)
1617

1718
## 6.46.0
1819

production/helm/loki/ci/non-default-values.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ loki:
66
commonConfig:
77
replication_factor: 1
88
useTestSchema: true
9-
storage:
10-
bucketNames:
11-
chunks: chunks
12-
ruler: ruler
139
tenants:
1410
- name: "test-user-1"
1511
password: "test-password-1"

production/helm/loki/templates/_helpers.tpl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ Generated storage config for loki common config
208208
object_store:
209209
{{- include "loki.thanosStorageConfig" (dict "ctx" . "bucketName" $bucketName) | nindent 2 }}
210210
{{- else if .Values.minio.enabled -}}
211-
{{- $bucketName := required "Please define loki.storage.bucketNames.chunks" (dig "storage" "bucketNames" "chunks" "" .Values.loki) }}
212211
s3:
213212
endpoint: {{ include "loki.minio" $ }}
214213
bucketnames: chunks

0 commit comments

Comments
 (0)