From b60591f2d0989af261b6df14c147932b832aa140 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= Date: Fri, 14 Nov 2025 16:40:03 +0100 Subject: [PATCH] fix(helm): do not mark loki.storage.bucketNames.chunks as required, if minio is used. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jan-Otto Kröpke --- production/helm/loki/CHANGELOG.md | 1 + production/helm/loki/ci/non-default-values.yaml | 4 ---- production/helm/loki/templates/_helpers.tpl | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/production/helm/loki/CHANGELOG.md b/production/helm/loki/CHANGELOG.md index 16066af359e23..5bcc94c02b447 100644 --- a/production/helm/loki/CHANGELOG.md +++ b/production/helm/loki/CHANGELOG.md @@ -13,6 +13,7 @@ Entries should include a reference to the pull request that introduced the chang ## Unreleased +- [BUGFIX] Do not mark loki.storage.bucketNames.chunks as required, if minio is used. [#19871](https://github.com/grafana/loki/pull/19871) ## 6.46.0 diff --git a/production/helm/loki/ci/non-default-values.yaml b/production/helm/loki/ci/non-default-values.yaml index ef27798a581b7..cf36592eddb68 100644 --- a/production/helm/loki/ci/non-default-values.yaml +++ b/production/helm/loki/ci/non-default-values.yaml @@ -6,10 +6,6 @@ loki: commonConfig: replication_factor: 1 useTestSchema: true - storage: - bucketNames: - chunks: chunks - ruler: ruler tenants: - name: "test-user-1" password: "test-password-1" diff --git a/production/helm/loki/templates/_helpers.tpl b/production/helm/loki/templates/_helpers.tpl index 34dcfaca76a6c..96ce5b734f685 100644 --- a/production/helm/loki/templates/_helpers.tpl +++ b/production/helm/loki/templates/_helpers.tpl @@ -208,7 +208,6 @@ Generated storage config for loki common config object_store: {{- include "loki.thanosStorageConfig" (dict "ctx" . "bucketName" $bucketName) | nindent 2 }} {{- else if .Values.minio.enabled -}} -{{- $bucketName := required "Please define loki.storage.bucketNames.chunks" (dig "storage" "bucketNames" "chunks" "" .Values.loki) }} s3: endpoint: {{ include "loki.minio" $ }} bucketnames: chunks