test: act fixes (#411)

Author: xnyo

.github/workflows/test-act.yml renamed to .github/workflows/pr-checks-test-ci.yml

@@ -9,9 +9,13 @@ on:
       - main
     paths:
       - "tests/**"
-      - ".github/workflows/test-act.yml"
+      - ".github/workflows/pr-checks-test-ci.yml"
       - ".github/workflows/ci.yml"
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 env:
   ACT_VERSION: v0.2.82
 
@@ -24,7 +28,7 @@ jobs:
     runs-on: ubuntu-x64-large
     steps:
       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           ref: ${{ github.event.pull_request.head.sha || github.ref }}
           fetch-depth: 0
@@ -47,7 +51,7 @@ jobs:
         shell: bash
 
       - name: Setup Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: tests/act/go.mod
           cache-dependency-path: tests/act/go.sum

tests/act/internal/act/act.go

@@ -69,19 +69,29 @@ func NewRunner(t *testing.T) (*Runner, error) {
 }
 
 // args returns the CLI arguments to pass to act for the given workflow and event payload files.
-func (r *Runner) args(workflowFile string, payloadFile string) []string {
+func (r *Runner) args(workflowFile string, payloadFile string) ([]string, error) {
 	pciwfRoot, err := os.Getwd()
 	if err != nil {
-		// TODO: do not fail silently
-		pciwfRoot = ""
+		return nil, fmt.Errorf("get working directory: %w", err)
 	}
+	f, err := os.Open(".release-please-manifest.json")
+	if err != nil {
+		return nil, fmt.Errorf("open .release-please-manifest.json: %w", err)
+	}
+	defer f.Close()
+	var releasePleaseManifest map[string]string
+	if err := json.NewDecoder(f).Decode(&releasePleaseManifest); err != nil {
+		return nil, fmt.Errorf("decode release-please-config.json: %w", err)
+	}
+	releasePleaseTag := "ci-cd-workflows/" + "v" + releasePleaseManifest[".github/workflows"]
 	args := []string{
 		"-W", workflowFile,
 		"-e", payloadFile,
 		"--rm",
 		"--json",
 		"--artifact-server-path=/tmp/artifacts/",
 		"--local-repository=grafana/plugin-ci-workflows@main=" + pciwfRoot,
+		"--local-repository=grafana/plugin-ci-workflows@" + releasePleaseTag + "=" + pciwfRoot,
 		"--secret", "GITHUB_TOKEN=" + r.gitHubToken,
 	}
 	if r.ConcurrentJobs > 0 {
@@ -91,7 +101,7 @@ func (r *Runner) args(workflowFile string, payloadFile string) []string {
 	for _, label := range selfHostedRunnerLabels {
 		args = append(args, "-P", label+"="+nektosActRunnerImage)
 	}
-	return args
+	return args, nil
 }
 
 // Run runs the given workflow with the given event payload using act.
@@ -111,7 +121,10 @@ func (r *Runner) Run(workflow workflow.Marshalable, eventPayload EventPayload) e
 	}
 	defer os.Remove(payloadFile)
 
-	args := r.args(workflowFile, payloadFile)
+	args, err := r.args(workflowFile, payloadFile)
+	if err != nil {
+		return fmt.Errorf("get act args: %w", err)
+	}
 
 	// TODO: escape args to avoid shell injection
 	actCmd := "act " + strings.Join(args, " ")