feat: support passing 'builder' parameter in push-to-gar-docker #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
We are trying to use the [buildkit-cache-dance][1] method to get better caching of our Go build cache in CI, but that requires having control over the buildx builder in our pipelines. This commit adds the 'builder' input to the push-to-gar-docker shared action, and conditionally creates a new builder if it isn't provided. [1]: https://github.com/reproducible-containers/buildkit-cache-dance/
sd2k
force-pushed
the
push-to-gar-docker-use-custom-builder
branch
from
072cda5 to
c87535d
Compare
guicaulada
reviewed
Nov 27, 2025
Member
guicaulada
left a comment
guicaulada
left a comment
There was a problem hiding this comment.
LGTM! Just 2 minor things.
Could you please update the README to include the new input?
Have you tested these changes on any workflow? Would be good to have a workflow run that shows this working in practice.
Author
|
Yep! we're using it here. README updated 🙂 |
guicaulada
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to use the buildkit-cache-dance method to get better caching of our Go build cache in CI, but that requires having control over the buildx builder in our pipelines. This commit adds the 'builder' input to the push-to-gar-docker shared action, and conditionally creates a new builder if it isn't provided.