Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor check handling functions #17

Open
Nilay-Shah opened this issue Mar 3, 2021 · 0 comments
Open

refactor check handling functions #17

Nilay-Shah opened this issue Mar 3, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Nilay-Shah
Copy link
Collaborator

there are now 2 spots (1, 2) where we have similar enough logic and we should consider refactoring these into a single spot. things to keep in mind:

  • we probably want to split this up into multiple functions
  • we want to avoid import loops (because we're using the config pkg to initialize new clients and whatnot)
@Nilay-Shah Nilay-Shah added the good first issue Good for newcomers label Mar 3, 2021
@Nilay-Shah Nilay-Shah mentioned this issue Mar 3, 2021
Merged
@Nilay-Shah Nilay-Shah self-assigned this Mar 16, 2021
@Nilay-Shah Nilay-Shah removed their assignment Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nilay-Shah