Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "push" mode for voucher subscriber #18

Open
ooq opened this issue Mar 9, 2021 · 1 comment
Open

Support "push" mode for voucher subscriber #18

ooq opened this issue Mar 9, 2021 · 1 comment
Assignees

Comments

@ooq
Copy link
Contributor

ooq commented Mar 9, 2021

Voucher subscriber currently supports a pull-based pub-sub subscription, i.e., the voucher subscriber will periodically pull for new messages.

An alternative mode is "push", where a subscription sends new messages to an http endpoint behind which the voucher subscriber runs.

Or, this feature should be added to voucher server instead?

Motivation:
The current pull based subscriber cannot be packaged to run on Google Cloud Run (or other microservice platform), due to its "serverful" nature.

cc @Nilay-Shah @cjones-shopify for comments.

@ooq ooq assigned Nilay-Shah and ghost Mar 9, 2021
@Nilay-Shah
Copy link
Collaborator

this is a good point; I don't think we considered the ability to have this run on serverless.

i think this makes the most sense to be part of the subscriber because this is another method of pub/sub. if i were using this package for the first time i'd expect something like voucher_subscriber push ... to work instead of having this functionality being a part of voucher_server ... even though the actual code for the push pub/sub option is pretty much the same as the actual Voucher server!

@ghost ghost assigned catherinejones and unassigned ghost Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants