Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from-until selection discrepancy existing series vs generated series #2269

Closed
pinkynrg opened this issue Mar 29, 2018 · 5 comments
Closed

from-until selection discrepancy existing series vs generated series #2269

pinkynrg opened this issue Mar 29, 2018 · 5 comments

Comments

@pinkynrg
Copy link

pinkynrg commented Mar 29, 2018

Considering the following query using a generated timeWalk series with granularity 5 minutes from February 1st to Match 1st:

http://graphite.faccousa.net/render?from=00:00_20180201&until=00:00_20180301&format=json&target[]=randomWalk('generated.sieres',300)

i get the following output:

[{"datapoints": [[0, 1517464800], [-0.2626011173480486, 1517464860], [-0.2215472735869829, 1517464920] ... ] ... }

in this case the first timestamp 1517464800 which is 2018-02-01 00:00:00.

now let's consider an actual existing metric with granularity 5 minutes, same time range as above:

http://graphite.faccousa.net/render?from=00:00_20180201&until=00:00_20180301&format=json&target[]=test.series.0

i get the following output:

[{"datapoints": [[null, 1517465100], [null, 1517465400], [null, 1517465700], ... ], ... }

The first timestamp is 1517465100 which is 2018-02-01 00:05:00 is not what i thought I would get (2018-02-01 00:00:00).

Is there a reason why the query doesn't include the midnight point in the first case?

@pinkynrg pinkynrg changed the title from-until selection discrepancy existing vs generate series from-until selection discrepancy existing vs generated series Apr 3, 2018
@pinkynrg pinkynrg changed the title from-until selection discrepancy existing vs generated series from-until selection discrepancy existing series vs generated series Apr 3, 2018
@pinkynrg
Copy link
Author

pinkynrg commented Apr 3, 2018

I can definitely check the code, all I'm asking is if there is a valid and known reason for this to be designed this way.

@deniszh
Copy link
Member

deniszh commented Apr 6, 2018

I'm not aware of any reasoning, looks like it's just "because of historical reasons".

@MatthewFin
Copy link

Is this setting at all configurable? It seems to be the case that existing metric queries includes the until param but excludes the from param.

I think that both ends of the from/until query should be inclusive, or at least configurable.

@piotr1212
Copy link
Member

Think this is a duplicate graphite-project/whisper#230

@stale
Copy link

stale bot commented Apr 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 13, 2020
@stale stale bot closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants