You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I mean only that specifically this dependency is somewhat different from the rest in the sense that it is not mandatory and it may not be obtained at all. I understand that one can pull all dependencies from HttpContext.RequestServices. I do not call for this - _documentExecuter and _serializer should be taken as dependencies. I'm saying more about not to consider any API for working with scopes as dependency. It's internal infrastructure code.
I was working on a PR for this just now -- but the WebSocket handler (which will be posted shortly) requires the service scope factory and cannot execute requests without it. So it may not make sense to remove it. In any case, it will be better to review the required changes after the WebSocket handling code is merged in rather than beforehand.
@sungam3r I reviewed this again. IServiceScopeFactory is required when executing batch requests and for any WebSocket connections. I'm not sure what change would be worth making here. Do you want to review this again? Let's discuss or close the issue.
I mean only that specifically this dependency is somewhat different from the rest in the sense that it is not mandatory and it may not be obtained at all. I understand that one can pull all dependencies from
HttpContext.RequestServices
. I do not call for this - _documentExecuter and _serializer should be taken as dependencies. I'm saying more about not to consider any API for working with scopes as dependency. It's internal infrastructure code.Originally posted by @sungam3r in #774 (comment)
The text was updated successfully, but these errors were encountered: