Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "database/sql.NullString" does not

[siddiquebagwan]

Hi, Graphql-go

Great library.
I found one issue.
Please find the detail of issue.

In my graphql object I have following fields

"SenderID": &graphql.Field{
       Type:        graphql.NewScalar(graphql.ScalarConfig{Name: "database/sql.NullString"}),
	Description: "The Senderid of the Address.",
},

Here Name field has / and . because my SenderID is of type database/sql.NullString and hence
At the time of creating Schema I am getting below error

ERROR: Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "database/sql.NullString" does not

graphql/definiation.go at line number 1333 has regx

var NameRegExp, _ = regexp.Compile("^[_a-zA-Z][_a-zA-Z0-9]*$")

As per this regx database/sql.NullString is not valid name. I updated this regx to ^[_a-zA-Z][_a-zA-Z0-9./]*$ and issue get resolved, I am able to perform query operation.

Could you please incorporate this fix,

Note: model is auto generated using xo and graphql objects are auto generated from model using graphql-go-generate

[sfriedel]

@mohdsiddique the official GraphQL spec specifies that all names have to match the regex [_A-Za-z][_0-9A-Za-z]* (source) so changing that one is IMO not really an option.

I think the better option would be to open an issue with graphql-go-generate because it seems it's generating type names which are not compatible with the GraphQL standard.

[siddiquebagwan]

Oh thanks I will open a issue with generator and mentioned this ticket as reference

On Mon, 29 Jan 2018 at 5:22 PM, Sebastian Friedel ***@***.***> wrote: @mohdsiddique <https://github.com/mohdsiddique> the official GraphQL spec specifies that all names have to match the regex [_A-Za-z][_0-9A-Za-z]* ( source <http://facebook.github.io/graphql/October2016/#sec-Names>) so changing that one is IMO not really an option. I think the better option would be to open an issue with graphql-go-generate because it seems it's generating type names which are not compatible with the GraphQL standard. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#273 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMlVEr59JPc_XeRkUm9pWCrPw7PNaC7Mks5tPbEZgaJpZM4Rvs-P> .

-- Sent from iPhone