Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why DeprecationReason is an empty string in introspection #713

Open
alimoli opened this issue Jan 29, 2025 · 1 comment
Open

Why DeprecationReason is an empty string in introspection #713

alimoli opened this issue Jan 29, 2025 · 1 comment

Comments

@alimoli
Copy link

alimoli commented Jan 29, 2025

I noticed that codegen, very popular tool to generate types from a schema, marks as deprecated all the possible types, queries, and mutations.
After some debugging I found out that the deprecationReason is returned by the introspection as an empty string.
For some reasons, codegen gives more importance to it than isDeprecated field (which is correctly set to false).
I checked around and I saw an old MR of @MarkKremer that fixed this problem.
But looking at the code now, it looks like that change has been reverted.
Any explanation for it?
I still think it makes sense to have the reason set to nil rather than an empty string.

Copy link

mentatbot bot commented Jan 29, 2025

If you would like me to solve this issue, either tag me in a comment or check this box:

  • Solve Issue

You can disable automatic comments on my settings page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant