fix: unhandled rejection in apollo plugin for apollo v3 (#6539)

Co-authored-by: Dotan Simha <[email protected]>
Co-authored-by: Laurin Quast <[email protected]>

Author: 3 people

.changeset/light-llamas-divide.md

@@ -0,0 +1,6 @@
+---
+'@graphql-hive/apollo': patch
+---
+
+Prevent GraphQL document with selection set not satisfiable by the server to cause unhandled
+rejections for Apollo Server v3 (see https://github.com/graphql-hive/console/pull/4958 and https://github.com/graphql-hive/console/issues/4935).

packages/libraries/apollo/src/index.ts

@@ -134,12 +134,29 @@ export function useHive(clientOrOptions: HiveClient | HivePluginOptions): Apollo
         } as any;
       }
 
+      let didFailValidation = false;
+
       if (isLegacyV3) {
         return Promise.resolve({
           didResolveSource() {
             didResolveSource = true;
           },
+          async validationDidStart() {
+            return function onErrors(errors) {
+              if (errors === null || errors === void 0 ? void 0 : errors.length) {
+                didFailValidation = true;
+              }
+            };
+          },
           async willSendResponse(ctx) {
+            if (didFailValidation) {
+              void complete(args, {
+                action: 'abort',
+                reason: 'Validation failed',
+                logging: false,
+              });
+              return;
+            }
             if (!didResolveSource) {
               void complete(args, {
                 action: 'abort',
@@ -165,8 +182,6 @@ export function useHive(clientOrOptions: HiveClient | HivePluginOptions): Apollo
         });
       }
 
-      let didFailValidation = false;
-
       return (async () => {
         let persistedDocumentError: GraphQLError | null = null;
         let persistedDocumentHash: string | undefined;