Go

Author: ardatan

babel.config.cjs

@@ -7,6 +7,8 @@ module.exports = {
     '@babel/preset-typescript',
   ],
   plugins: [
+    ['@babel/plugin-transform-class-static-block', { version: '2023-11' }],
+    ['@babel/plugin-proposal-decorators', { version: '2023-11' }],
     '@babel/plugin-transform-class-properties',
     '@babel/plugin-proposal-explicit-resource-management',
   ],

e2e/nestjs/nestjs.e2e.ts

@@ -6,7 +6,7 @@ import { expect, it } from 'vitest';
 const { service } = createTenv(__dirname);
 const { supergraph, query, result } = createExampleSetup(__dirname);
 
-it('executes the query', async () => {
+it.todo('executes the query', async () => {
   const supergraphPath = await supergraph();
   const { port } = await service('nestjs', {
     args: [`--supergraph=${supergraphPath}`],

e2e/nestjs/services/nestjs.ts

@@ -0,0 +1,17 @@
+import { HiveGatewayDriver, HiveGatewayDriverConfig } from "@graphql-hive/nestjs";
+import { Opts } from "@internal/testing";
+import { Module } from "@nestjs/common";
+import { GraphQLModule } from "@nestjs/graphql";
+
+const opts = Opts(process.argv);
+const supergraph = opts.get('supergraph', true);
+
+@Module({
+    imports: [
+        GraphQLModule.forRoot<HiveGatewayDriverConfig>({
+            driver: HiveGatewayDriver,
+            supergraph,
+        }),
+    ],
+})
+export class AppModule { }

e2e/nestjs/services/nestjs/app.module.ts

@@ -0,0 +1,16 @@
+import { NestFactory } from "@nestjs/core";
+import { AppModule } from "./app.module";
+import { Opts } from "@internal/testing";
+
+const opts = Opts(process.argv);
+const port = opts.getServicePort('nestjs', true);
+
+async function main() {
+    const app = await NestFactory.create(AppModule);
+    await app.listen(port);
+}
+
+main().catch((err) => {
+    console.error(err);
+    process.exit(1);
+});

e2e/nestjs/services/nestjs/index.ts

@@ -9,7 +9,7 @@ const rootDir = __dirname;
 const tsconfigPath = resolve(rootDir, 'tsconfig.json');
 const tsconfigContents = readFileSync(tsconfigPath, 'utf8');
 const tsconfig = JSON5.parse(tsconfigContents);
-const ESM_PACKAGES = ['graphql-federation-gateway-audit'];
+const ESM_PACKAGES = ['graphql-federation-gateway-audit', 'parse-duration'];
 
 export default {
   testEnvironment: 'node',

jest.config.ts

@@ -27,8 +27,10 @@
   },
   "devDependencies": {
     "@babel/core": "7.26.9",
+    "@babel/plugin-proposal-decorators": "7.25.9",
     "@babel/plugin-proposal-explicit-resource-management": "7.25.9",
     "@babel/plugin-transform-class-properties": "7.25.9",
+    "@babel/plugin-transform-class-static-block": "7.26.0",
     "@babel/preset-env": "7.26.9",
     "@babel/preset-typescript": "7.26.0",
     "@changesets/changelog-github": "^0.5.0",

package.json

@@ -40,8 +40,8 @@
     "prepack": "yarn build"
   },
   "peerDependencies": {
-    "@nestjs/common": "^11.0.10",
-    "@nestjs/graphql": "^13.0.3",
+    "@nestjs/common": "^10 || ^11",
+    "@nestjs/graphql": "^12 || ^13",
     "graphql": "^15.9.0 || ^16.9.0"
   },
   "dependencies": {
@@ -55,11 +55,14 @@
     "@nestjs/common": "11.0.10",
     "@nestjs/core": "11.0.10",
     "@nestjs/graphql": "13.0.3",
+    "@nestjs/testing": "11.0.11",
+    "@types/supertest": "6.0.2",
     "fastify": "5.2.1",
     "graphql": "^16.9.0",
     "pkgroll": "2.10.0",
     "reflect-metadata": "0.2.2",
-    "rxjs": "7.8.1"
+    "rxjs": "7.8.1",
+    "supertest": "7.0.0"
   },
   "sideEffects": false
 }

packages/nestjs/package.json

@@ -49,8 +49,8 @@ export type HiveGatewayDriverConfig<
 export class HiveGatewayDriver<
   TContext extends Record<string, any>,
 > extends AbstractGraphQLDriver<HiveGatewayDriverConfig<TContext>> {
-  #gatewayRuntime: GatewayRuntime<TContext> | undefined;
-  #subscriptionService?: GqlSubscriptionService;
+  private _gatewayRuntime: GatewayRuntime<TContext> | undefined;
+  private _subscriptionService?: GqlSubscriptionService;
 
   public async start({
     schema,
@@ -87,7 +87,7 @@ export class HiveGatewayDriver<
       ...configCtx,
       cache,
     });
-    this.#gatewayRuntime = createGatewayRuntime({
+    this._gatewayRuntime = createGatewayRuntime({
       logging: configCtx.logger,
       cache,
       graphqlEndpoint: options.path,
@@ -133,7 +133,7 @@ export class HiveGatewayDriver<
         options.subscriptions || { 'graphql-ws': {} };
       if (subscriptionsOptions['graphql-ws']) {
         const gwOptions = getGraphQLWSOptions<TContext, any>(
-          this.#gatewayRuntime,
+          this._gatewayRuntime,
           (ctx) => ({
             req: ctx.extra?.request,
             socket: ctx.extra?.socket,
@@ -161,7 +161,7 @@ export class HiveGatewayDriver<
           },
           ws: WebSocket,
         ) => {
-          if (!this.#gatewayRuntime) {
+          if (!this._gatewayRuntime) {
             throw new Error('Hive Gateway is not initialized');
           }
           const {
@@ -171,7 +171,7 @@ export class HiveGatewayDriver<
             contextFactory,
             parse,
             validate,
-          } = this.#gatewayRuntime.getEnveloped({
+          } = this._gatewayRuntime.getEnveloped({
             ...params.context,
             req:
               // @ts-expect-error upgradeReq does exist but is untyped
@@ -197,9 +197,9 @@ export class HiveGatewayDriver<
           return args;
         };
       }
-      this.#subscriptionService = new GqlSubscriptionService(
+      this._subscriptionService = new GqlSubscriptionService(
         {
-          schema: await this.#gatewayRuntime.getSchema(),
+          schema: await this._gatewayRuntime.getSchema(),
           path: options.path,
           // @ts-expect-error - We know that execute and subscribe are defined
           execute: (args) => args.rootValue.execute(args),
@@ -213,23 +213,23 @@ export class HiveGatewayDriver<
   }
 
   public async stop(): Promise<void> {
-    await this.#subscriptionService?.stop();
-    await this.#gatewayRuntime?.dispose();
+    await this._subscriptionService?.stop();
+    await this._gatewayRuntime?.dispose();
   }
 
   private registerExpress() {
-    this.httpAdapterHost.httpAdapter.use(this.#gatewayRuntime);
+    this.httpAdapterHost.httpAdapter.use(this._gatewayRuntime);
   }
   private registerFastify() {
     this.httpAdapterHost.httpAdapter
       .getInstance()
       .all('*', async (req: FastifyRequest, reply: FastifyReply) => {
-        if (!this.#gatewayRuntime) {
+        if (!this._gatewayRuntime) {
           throw new Error('Hive Gateway is not initialized');
         }
         // Second parameter adds Fastify's `req` and `reply` to the GraphQL Context
         const response =
-          await this.#gatewayRuntime.handleNodeRequestAndResponse(req, reply, {
+          await this._gatewayRuntime.handleNodeRequestAndResponse(req, reply, {
             req,
             reply,
           });

packages/nestjs/src/index.ts

@@ -0,0 +1,77 @@
+import { buildSubgraphSchema } from '@apollo/subgraph';
+import { AsyncDisposableStack } from '@whatwg-node/disposablestack';
+import {
+  HiveGatewayDriver,
+  HiveGatewayDriverConfig,
+} from '../src';
+import {
+  composeLocalSchemasWithApollo,
+  createDisposableServer,
+} from '@internal/testing';
+import { INestApplication } from '@nestjs/common';
+import { GraphQLModule } from '@nestjs/graphql';
+import { Test } from '@nestjs/testing';
+import { parse } from 'graphql';
+import { createYoga } from 'graphql-yoga';
+import supertest from 'supertest';
+import { afterAll, beforeAll, describe, it } from 'vitest';
+
+describe.skipIf(process.env['LEAK_TEST'])('NestJS', () => {
+  let app: INestApplication;
+  const disposableStack = new AsyncDisposableStack();
+  beforeAll(async () => {
+    const upstreamSchema = buildSubgraphSchema({
+      typeDefs: parse(/* GraphQL */ `
+        type Query {
+          hello: String!
+        }
+      `),
+      resolvers: {
+        Query: {
+          hello: () => 'world',
+        },
+      },
+    });
+    const upstreamYoga = createYoga({
+      schema: upstreamSchema,
+    });
+    disposableStack.use(upstreamYoga);
+    const upstreamServer = await createDisposableServer(upstreamYoga);
+    disposableStack.use(upstreamServer);
+    const supergraph = await composeLocalSchemasWithApollo([
+      {
+        name: 'upstream',
+        schema: upstreamSchema,
+        url: `${upstreamServer.url}/graphql`,
+      },
+    ]);
+    const moduleRef = await Test.createTestingModule({
+      imports: [
+        GraphQLModule.forRoot<HiveGatewayDriverConfig>({
+          driver: HiveGatewayDriver,
+          supergraph,
+        }),
+      ],
+    }).compile();
+    app = moduleRef.createNestApplication();
+    disposableStack.defer(() => app.close());
+    return app.init();
+  });
+  afterAll(() => disposableStack.disposeAsync());
+  it('works', () => {
+    return supertest(app.getHttpServer())
+      .post('/graphql')
+      .send({
+        query: /* GraphQL */ `
+          query {
+            hello
+          }
+        `,
+      })
+      .expect(200, {
+        data: {
+          hello: 'world',
+        },
+      });
+  });
+});