Skip to content

Commit 449ee3d

Browse files
authored
Merge branch 'main' into UXRFC-439
2 parents 1cb5bc8 + 3f580e1 commit 449ee3d

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

src/components/FilePreview/FilePreview.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ $smallRoundedButtonSize: 24px;
135135
width: 96px;
136136
}
137137

138-
&-image {
138+
&__image {
139139
position: absolute;
140140
inset-block-start: 0;
141141
inset-inline-start: 0;

src/components/Sheet/SheetContent.tsx

+13-2
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ interface SheetContentState {
5959
veilTouched: boolean;
6060
isAnimating: boolean;
6161
inWindowResizeScope: boolean;
62+
delayedResize: boolean;
6263
}
6364

6465
class SheetContent extends React.Component<SheetContentInnerProps, SheetContentState> {
@@ -86,6 +87,7 @@ class SheetContent extends React.Component<SheetContentInnerProps, SheetContentS
8687
veilTouched: false,
8788
isAnimating: false,
8889
inWindowResizeScope: false,
90+
delayedResize: false,
8991
};
9092

9193
componentDidMount() {
@@ -333,12 +335,14 @@ class SheetContent extends React.Component<SheetContentInnerProps, SheetContentS
333335
y: e.nativeEvent.touches[0].clientY,
334336
});
335337

336-
this.setState({deltaY: delta});
337-
338+
// if allowHideOnContentScroll is true and delta <= 0, it's a content scroll
339+
// animation is not needed
338340
if (delta <= 0) {
341+
this.setState({deltaY: 0});
339342
return;
340343
}
341344

345+
this.setState({deltaY: delta});
342346
this.setStyles({status: 'showing', deltaHeight: delta});
343347
};
344348

@@ -397,6 +401,12 @@ class SheetContent extends React.Component<SheetContentInnerProps, SheetContentS
397401

398402
if (this.veilOpacity === '0') {
399403
this.props.hideSheet();
404+
return;
405+
}
406+
407+
if (this.state.delayedResize) {
408+
this.onResizeWindow();
409+
this.setState({delayedResize: false});
400410
}
401411
};
402412

@@ -410,6 +420,7 @@ class SheetContent extends React.Component<SheetContentInnerProps, SheetContentS
410420

411421
private onResizeWindow = () => {
412422
if (this.state.isAnimating) {
423+
this.setState({delayedResize: true});
413424
return;
414425
}
415426

0 commit comments

Comments
 (0)