chore: update types for React 19 compatibility #2522
Conversation
e-yushkiavichus
requested review from
DaryaLari,
IsaevAlexandr,
NikitaCG,
Raubzeug,
ValeraS,
amje,
korvin89,
kseniya57 and
ogonkov
as code owners
|
Preview is ready. |
|
🎭 Component Tests Report is ready. |
| ref={ | ||
| this.state.columnHeaderRefs[ | ||
| index | ||
| ] as React.Ref<HTMLTableCellElement> |
There was a problem hiding this comment.
Why we need to cast type here?
There was a problem hiding this comment.
columnHeaderRefs is typed as React.RefObject<HTMLTableCellElement | null>[] (to align with React 19, where RefObject<T> no longer allows null in current without explicit typing). When accessing this.state.columnHeaderRefs[index], we get RefObject<HTMLTableCellElement | null>, while the ref prop on <th> expects Ref<HTMLTableCellElement> (which is RefCallback<T> | RefObject<T> | null).
TypeScript treats RefObject<HTMLTableCellElement | null> as structurally incompatible with RefObject<HTMLTableCellElement> (even though they're functionally equivalent at runtime, since both have current: HTMLTableCellElement | null). The assertion bridges this structural type mismatch.
#2459