Skip to content

[FEAT] Accessibility updates for DaffMenuComponent #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xelaint opened this issue Jun 10, 2024 · 2 comments · May be fixed by #2888
Open

[FEAT] Accessibility updates for DaffMenuComponent #2841

xelaint opened this issue Jun 10, 2024 · 2 comments · May be fixed by #2888
Assignees
@damienwebdev @xelaint
Labels
accessibility This issue is related to accessibility package: design @daffodil/design status: blocked This PR or issue is blocked and cannot currently be progressed
Milestone
Daffodil v1.0

Comments

@xelaint
Copy link
Member

xelaint commented Jun 10, 2024 •
edited
Loading

💡 Feature request

Feature Name

Accessibility updates for DaffMenuComponent

The Desired Behavior

  1. aria-controls on the daffMenuActivator
  2. aria-haspopup and aria-expanded on DaffMenuComponent
  3. Arrow key functionalities (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/menu_role)

Your Use Case

As a developer, I need to provide an accessible menu component for users.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:
@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design accessibility This issue is related to accessibility labels Jun 10, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jun 10, 2024
@xelaint xelaint self-assigned this Jun 10, 2024
@xelaint xelaint linked a pull request Jun 21, 2024 that will close this issue
Draft
3 tasks
@xelaint
Copy link
Member Author

xelaint commented Jan 9, 2025

Currently blocked because aria-controls implementation doesn't work if using template ref to implement menu

@xelaint xelaint added the status: blocked This PR or issue is blocked and cannot currently be progressed label Jan 9, 2025
@xelaint xelaint removed the feat a new feature, enhancement, or improvement label Jan 17, 2025
@damienwebdev damienwebdev self-assigned this Feb 20, 2025
@xelaint
Copy link
Member Author

xelaint commented Mar 18, 2025

May no longer need to use templateRef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienwebdev damienwebdev

@xelaint xelaint

Labels
accessibility This issue is related to accessibility package: design @daffodil/design status: blocked This PR or issue is blocked and cannot currently be progressed
Projects
None yet
Milestone
Daffodil v1.0
Development

Successfully merging a pull request may close this issue.

feat(design)!: add support for aria-controls to menu graycoreio/daffodil
2 participants
@damienwebdev @xelaint