Skip to content

Commit c1b3114

Browse files
committed
Added check for existing image name (local vs cloud build)
1 parent 6b5fbf9 commit c1b3114

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ This project adheres to [Semantic Versioning][semver].
88

99
Refer to master branch
1010

11-
## \[v1.1.1\] - 2019-10-13
11+
## \[v1.1.1\] - 2019-10-14
1212

13-
### Split PHP builds, PHP FPM:
13+
### Split PHP builds, PHP FPM, Latest tag:
1414
- Split builds by PHP version and variant
1515
- Use builds Docker hooks in Makefile
1616
- Added `fpm` variant

build/hooks/_common

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,9 @@ if [ -n "${DOCKER_TAG}" ]; then
3333
fi
3434
fi
3535

36+
HAS_IMAGE_NAME=
37+
if [ -n "$IMAGE_NAME" ];then
38+
HAS_IMAGE_NAME=1
39+
fi
40+
3641
echo

build/hooks/build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ for php_version in $PHP_VERSIONS; do
1717
xdebug_version=-2.5.5
1818
fi
1919
for php_variant in $PHP_VARIANTS; do
20-
if [ -z "$IMAGE_NAME" ]; then
20+
if [ -z "$HAS_IMAGE_NAME" ] || [ -z "$IMAGE_NAME" ]; then
2121
IMAGE_NAME="$DOCKER_REPO:$php_version-$php_variant-$SOURCE_BRANCH"
2222
echo ">>> Set IMAGE_NAME to: $IMAGE_NAME"
2323
fi

build/hooks/post_push

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ SEMVER_REGEX="^(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)\\.(0|[1-9][0-9]*)(\\-[0-9A-Za-z
1414

1515
for php_version in $PHP_VERSIONS; do
1616
for php_variant in $PHP_VARIANTS; do
17-
if [ -z "$IMAGE_NAME" ]; then
17+
if [ -z "$HAS_IMAGE_NAME" ] || [ -z "$IMAGE_NAME" ]; then
1818
IMAGE_NAME="$DOCKER_REPO:$php_version-$php_variant-$SOURCE_BRANCH"
1919
echo ">>> Set IMAGE_NAME to: $IMAGE_NAME"
2020
fi

0 commit comments

Comments
 (0)