-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirect_uri protocol issue #12
Comments
I think the key difference is the value of the Could you share the details of what's handling |
@dsagal thanks for replying. Yes, I already have Traefik on a different box handling traffic and certs. I also tried the forward proto. So I connect https just fine with this setup. There is no issue until I click one of the three login options (Login with email,Google, Ms). That's when the http error pops up. |
And does you `URL` variable start with `https://` (not `http://`)?
…On Sun, Dec 3, 2023 at 10:33 PM sugarfunk ***@***.***> wrote:
@dsagal <https://github.com/dsagal> thanks for replying.
Yes, I already have Traefik on a different box handling traffic and certs.
I also tried the forward proto.
So I connect https just fine with this setup. There is no issue until I
click one of the three login options (Login with email,Google, Ms). That's
when the http error pops up.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIKMR7ZAHGEMKS2PKUWEQDYHVABVAVCNFSM6AAAAABAEJCZTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG44DKMRVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
URL variable starts with https. Switching to http results in a white screen and logs reporting errors that http is not supported.
…On Sun, Dec 3, 2023 at 10:38 PM, Dmitry ***@***.***(mailto:On Sun, Dec 3, 2023 at 10:38 PM, Dmitry <<a href=)> wrote:
And does you `URL` variable start with `https://` (not `http://`)?
On Sun, Dec 3, 2023 at 10:33 PM sugarfunk ***@***.***> wrote:
> @dsagal <https://github.com/dsagal> thanks for replying.
>
> Yes, I already have Traefik on a different box handling traffic and certs.
> I also tried the forward proto.
>
> So I connect https just fine with this setup. There is no issue until I
> click one of the three login options (Login with email,Google, Ms). That's
> when the http error pops up.
>
> —
> Reply to this email directly, view it on GitHub
> <#12 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAIKMR7ZAHGEMKS2PKUWEQDYHVABVAVCNFSM6AAAAABAEJCZTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG44DKMRVGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, [view it on GitHub](#12 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAKMQKSHPD7QA722YSK2B63YHVAUXAVCNFSM6AAAAABAEJCZTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXG44DQNZSGY).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I'm having this issue as well, and I have same setup as #6 except and if you try to change
|
Hi, |
I found the issue, and have PR #13 that addresses it. You can give it a shot as follows:
I'd appreciate your feedback on whether it is indeed sufficient for your setup. |
The latest docker image includes the fix. The README includes these updated instructions for when running behind another reverse proxy:
|
Hi, I have npm on a seperate host where I am terminating SSL. My env variables: When i start the container, I get the following error in the logs : <> when accessing the app through browser, I get ERR_TOO_MANY_REDIRECTS. I am not sure if I have messed up something in npm or its something to do with grist. Thanks in advance. |
@ibarot1981 , what the container is doing is checking that the services it's running (such as Dex) are actually accessible at the URL you configured. It should be making a fetch to the exact URL you specified. Sometimes it's tricky to ensure that the public URL you configured is also accessible from inside the container. |
Hi, thanks for your reply. I am not sure how to proceed here. Before I stumbled along this issue here, I followed the docker compose guide here Since I am terminating SSL at NPM on a seperate host, earlier I gave the following env values : I could get the login page and also login with the EMAIL and PASSWORD variables as provided but immediately after login I got an error on the browser. at this point, nothing worked and it got stuck at this page. On searching I found this thread and so I added HTTPS=external and TRUSTED_PROXY_IPS= my internal IP for NPM Is there anything more I need to do apart from adding the above two variables and changing URL from http to https? Thank you. |
Hmm, I attempted to test, and I am getting the "418 I am a teapot" response code for everything, which is stumping me. I'll have to come back later to figure out what's wrong with my setup (it's not a clean slate). Also, there have been a few changes recently, and it's possible something broke again for As far as things to check:
|
I am also getting the "too many redirects" / "FetchError:maximum redirect reached" error with grist checking for dex. Seems like a traefik redirect loop inside the container. I have:
If I just run Also in my logs I see: yet in my dex.yaml I have
|
I narrowed down my issue (the redirect loop) to HTTPS=external. I added another dedicated IP address to my box (so it doesn't conflict with nginx), changed the config to use it, remapped the ports, and everything starts up and works with HTTPS=auto. So yeah, HTTPS=external is broken. |
external seeming to be broken is now a blocker for me. |
Having the same problem with grist-omnibus and NPM. I have installed grist-omnibus on docker on a Synology NAS using portainer. I also run NPM (Nginx-Proxy-Manager) as a reverse-proxy server for all my docker containers. Has anyone found a solution to get this working with NPM (external reverse-proxy server)? Here is my docker-compose file:
Here is the log:
|
@Spoffy do you know happen to know if
followed by a:
|
Hello. I'm also experiencing the same issue. Have any solutions been found to deal with this? I have grist running on easypanel which runs a traefik instance as a reverse proxy infront of multiple apps. |
I am running into the same issue as #6 but not able to resolve with the same troubleshooting. No matter what I do oauth is using http and thus failing.
My Docker Compose
Loads fine, but after clicking login with email I get this.
![image](https://private-user-images.githubusercontent.com/1361962/287484658-f414eac0-8f2e-42b2-9fe9-906f04e2a8ef.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODEwMTcsIm5iZiI6MTczOTI4MDcxNywicGF0aCI6Ii8xMzYxOTYyLzI4NzQ4NDY1OC1mNDE0ZWFjMC04ZjJlLTQyYjItOWZlOS05MDZmMDRlMmE4ZWYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTMzMTU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjE0YTJhYWJjYzhmNWU5MzRmNWM2NzMzM2U1ZWQ3NGVhNjZhNTNjN2Q4ODA4Nzk1YTNlMmNiZjcxNmFlM2VkZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.OI2oYcJum1IrT674X9Eb7sNR--cdalk0X1luWxhUyk8)
and here is the related log/error
The text was updated successfully, but these errors were encountered: