Skip to content

Commit 2b95bf7

Browse files
committed
Fix random number generation
Untested code is broken code :(
1 parent 1bd0ed8 commit 2b95bf7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/crypto.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ apr_status_t SEAL_KEY_CREATE(apr_pool_t *p, struct seal_key **skey,
5858
memcpy(n->hkey, keys->value + keylen, keylen);
5959
} else {
6060
ret = apr_generate_random_bytes(n->ekey, keylen);
61-
if (ret == 0) {
61+
if (ret != 0) {
6262
ret = EFAULT;
6363
goto done;
6464
}
6565

6666
ret = apr_generate_random_bytes(n->hkey, keylen);
67-
if (ret == 0) {
67+
if (ret != 0) {
6868
ret = EFAULT;
6969
goto done;
7070
}
@@ -99,7 +99,7 @@ apr_status_t SEAL_BUFFER(apr_pool_t *p, struct seal_key *skey,
9999
/* confounder to avoid exposing random numbers directly to clients
100100
* as IVs */
101101
ret = apr_generate_random_bytes(rbuf, sizeof(rbuf));
102-
if (ret == 0) goto done;
102+
if (ret != 0) goto done;
103103

104104
if (cipher->length == 0) {
105105
/* add space for confounder and padding and MAC */

0 commit comments

Comments
 (0)